Adding golang example#16
Open
KennethThompson wants to merge 2 commits into
Open
Conversation
kou
reviewed
Jul 6, 2022
Member
kou
left a comment
There was a problem hiding this comment.
Thanks!
Can I push fixes to this branch directly or do you want to fix by yourself?
Here are items we need to fix:
- Remove
.vscode/: It seems that it depends on your environment. - Revert needless change in
examples/sql.py. - Add license header to
examples/sql.go. - Add a step to our CI job to run
examples/sql.go. - Add a configuration to build
examples/sql.gointoexamples/meson.build. - Add a description about
examples/sql.gointoREADME.md.
Author
|
I'll give it a shot. I was once useful, but now its hit or miss. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry- I am new to pull requests so some extra bits got swept in. Please consider adding the sql.go