Skip to content

Adding golang example#16

Open
KennethThompson wants to merge 2 commits into
datafusion-contrib:mainfrom
KennethThompson:main
Open

Adding golang example#16
KennethThompson wants to merge 2 commits into
datafusion-contrib:mainfrom
KennethThompson:main

Conversation

@KennethThompson
Copy link
Copy Markdown

Sorry- I am new to pull requests so some extra bits got swept in. Please consider adding the sql.go

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can I push fixes to this branch directly or do you want to fix by yourself?

Here are items we need to fix:

  • Remove .vscode/: It seems that it depends on your environment.
  • Revert needless change in examples/sql.py.
  • Add license header to examples/sql.go.
  • Add a step to our CI job to run examples/sql.go.
  • Add a configuration to build examples/sql.go into examples/meson.build.
  • Add a description about examples/sql.go into README.md.

@KennethThompson
Copy link
Copy Markdown
Author

I'll give it a shot. I was once useful, but now its hit or miss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants