-
Notifications
You must be signed in to change notification settings - Fork 26
Add task progression tracking in ddf console #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add task progression tracking in ddf console #330
Conversation
- console now connects to workers with a RegisterWorker rpc
- discovery only needs to be implemented on the client side
- added examples in console/examples
- seperated console source files into ui, app, and main
- tasks upon completion are removed from the TTL Map which was causing progress bars to shrink and grow with the number of the tasks being worked on, not the number of tasks completed
gabotechs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not done a full review of the PR, I just took a quick first look and everything looks really promising!
I just have one comment about one challenge that we might not have anticipated, that would require a relatively major adaptation probably in a separate PR, so for now I'll just leave that comment.
I think this is about to get a bit complicated in a very data structure/algorithmic way...
e42c4aa to
a75598e
Compare
Summary
GetTaskProgressRPCRegisterWorkersRPC for worker discoveryconsole/examples/console.md)console/src/main.rs,console/src/app.rs,console/src/ui.rs)See
console/examples/tpcds_runner.mdand run TPC-DS query 99 for a good example of the console in actionOther changes
TaskDataTaskDataStageKey