Just assert cherry-picked plans in tests #338
Closed
+94
−11,937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I'm not sure if we should merge this in. This happen to have saved my ass several times already in the last few days. I'm going to close for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diffs for PRs that touch planning logic are getting pretty massive. This is mainly because of the amount of insta snapshots we have for testing plans.
Before, we were following a machine gun approach of asserting all plans for TPC-H, TPC-DS and Clickbench.
Now, this PR cherry picks just a some plans that I think might be relevant. This way, the diff will become more manageable.