Move all test utils to src/ and hide them behind an "integration" feature - #84
Merged
Merged
Conversation
gabotechs
force-pushed
the
gabrielmusat/move-common-test-utils-to-one-place
branch
3 times, most recently
from
August 8, 2025 11:24
f66733c to
6766309
Compare
…ture. This way, other crates and integration tests as well can use it
gabotechs
force-pushed
the
gabrielmusat/move-common-test-utils-to-one-place
branch
from
August 8, 2025 11:34
6766309 to
6a8b5b0
Compare
…text (#85) * Move all test utils to src/ and hide them behind an "integration" feature. This way, other crates and integration tests as well can use it * Extend the `SessionBuilder` trait to be able to operate not only at the `SessionStateBuilder` level, but also on `SessionState` and `SessionContext` * Add benchmarks crate by copying upstream DataFusion code (#73) * Add benchmarks crate by copying upstream DataFusion code * Wire-up distributed execution with tpch benchmarks (#86)
robtandy
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves around the test utilities so that they can be used in more places:
src/test_utils/andtests/common/src/test_utils"integration"featureThe rationale for this is that we can expect this test utilities to be used in more places apart from just the integration tests in
tests/, like benchmarking for example.DX change: before the integration tests run normally on every
cargo test, now they run just if the feature"integration"is enabled (cargo test --feature integration)