Reuse DuckDB connection for metadata queries instead of creating new connection per call#43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DuckdbMetadataProviderto use a single shared DuckDB connection protected byArc<Mutex<Connection>>instead of creating a new connection for each metadata query#44
Changes
catalog_path: Stringtoconn: Arc<Mutex<Connection>>new()and reused across all metadata callsconnection()method that returnsMutexGuard<Connection>for thread-safe accessopen_connection_with_path()tocreate_connection()for clarityRationale
Previously, each of the 14+ metadata methods (
get_current_snapshot,list_schemas,get_table_by_name, etc.) opened a new DuckDB connection. Since all operations are read-only and metadata queries are fast, a mutex-protected shared connection is sufficient and eliminates unnecessary connection overhead.