Add TLP Having Oracle#3
Conversation
…into TLP-having
|
@2010YOUY01 Please take a look when available! |
2010YOUY01
left a comment
There was a problem hiding this comment.
Thank you, this PR is well written. I have left some minor suggestions for you to consider.
A potential follow-up to do for better test coverage is supporting aggregate expressions in the select statement.
I also plan to clean up the README and move this repo to https://github.com/datafusion-contrib shortly. After that, the next steps are to add sufficient test coverage so it can consistently detect bugs, and later write a blog post and start doing CI integration.
|
@2010YOUY01 please check again.
I'll work on it in the next PR.
🚀 We can start filing issues for different oracles and other improvements once you do |
Builds on top of #2.
Added group by, having support for select statement.
Moved our common TLP logic out of TLP Where Oracle.
Added a TLP Having Oracle.