Skip to content

Add TLP Having Oracle#3

Merged
2010YOUY01 merged 14 commits into
datafusion-contrib:mainfrom
sdf-jkl:TLP-having
Apr 7, 2026
Merged

Add TLP Having Oracle#3
2010YOUY01 merged 14 commits into
datafusion-contrib:mainfrom
sdf-jkl:TLP-having

Conversation

@sdf-jkl
Copy link
Copy Markdown
Contributor

@sdf-jkl sdf-jkl commented Mar 16, 2026

Builds on top of #2.

Added group by, having support for select statement.

Moved our common TLP logic out of TLP Where Oracle.

Added a TLP Having Oracle.

@sdf-jkl sdf-jkl changed the title Tlp having Oracle Add TLP Having Oracle Mar 16, 2026
@sdf-jkl sdf-jkl marked this pull request as draft March 24, 2026 22:30
@sdf-jkl sdf-jkl marked this pull request as ready for review March 30, 2026 20:54
@sdf-jkl
Copy link
Copy Markdown
Contributor Author

sdf-jkl commented Mar 30, 2026

@2010YOUY01 Please take a look when available!

Copy link
Copy Markdown
Collaborator

@2010YOUY01 2010YOUY01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this PR is well written. I have left some minor suggestions for you to consider.

A potential follow-up to do for better test coverage is supporting aggregate expressions in the select statement.

I also plan to clean up the README and move this repo to https://github.com/datafusion-contrib shortly. After that, the next steps are to add sufficient test coverage so it can consistently detect bugs, and later write a blog post and start doing CI integration.

Comment thread src/oracle/oracle_common.rs Outdated
Comment thread src/query_generator/stmt_select_def.rs Outdated
@sdf-jkl
Copy link
Copy Markdown
Contributor Author

sdf-jkl commented Apr 2, 2026

@2010YOUY01 please check again.

A potential follow-up to do for better test coverage is supporting aggregate expressions in the select statement.

I'll work on it in the next PR.

I also plan to clean up the README and move this repo to https://github.com/datafusion-contrib shortly. After that, the next steps are to add sufficient test coverage so it can consistently detect bugs, and later write a blog post and start doing CI integration.

🚀 We can start filing issues for different oracles and other improvements once you do

@2010YOUY01 2010YOUY01 merged commit 5326340 into datafusion-contrib:main Apr 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants