Support view matcher with boolean binary operation#117
Merged
xudong963 merged 1 commit intoMar 9, 2026
Merged
Conversation
Contributor
Author
|
cc @xudong963 @matthewmturner , port our internal feature to upstream. |
There was a problem hiding this comment.
Pull request overview
Adds canonicalization for boolean column comparisons so semantically equivalent predicates (e.g., col = false vs NOT col) can match during MV rewrites, with new tests validating the behavior.
Changes:
- Normalize
col = true/falseandcol != true/falseinto canonical residual expressions (col/NOT col). - Add test coverage ensuring MV/query predicate equivalence for boolean expressions (
NOT colvscol = false, andcolvscol = true).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
xudong963
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support view matcher with boolean binary operation, and added test.