feat: add --dir option for the cli#82
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new --dir option for the CLI to automatically register supported files in a specified directory as tables. In addition, it adjusts public re-exports in the library and updates the usage information in the README.
- Introduces a new method to include directory files by reading file extensions and adding them to corresponding table lists.
- Adjusts public API usage in the library and updates CLI arguments including new flags for --dir and --host.
- Updates README documentation to reflect version changes and CLI usage.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| datafusion-postgres/src/lib.rs | Updates public re-exports and internal module use for HandlerFactory. |
| datafusion-postgres-cli/src/main.rs | Implements the directory file inclusion logic and updates CLI flags. |
| README.md | Adjusts version, command usage and help text to reflect new options. |
Comments suppressed due to low confidence (1)
datafusion-postgres/src/lib.rs:13
- [nitpick] The public re-export for HandlerFactory has been removed; if this change is intentional to encapsulate implementation details, consider adding a comment or documentation to clarify the rationale.
use handlers::HandlerFactory;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dir option allows user to load all supported files from a directory.
There is also a minor refactoring to remove
HandlerFactoryfrom public API of the library. It's replaced by higher level apiserve.