Skip to content

Upgrade to DataFusion 46#309

Merged
phillipleblanc merged 2 commits into
mainfrom
phillip/250409-upgrade-df-46
Apr 10, 2025
Merged

Upgrade to DataFusion 46#309
phillipleblanc merged 2 commits into
mainfrom
phillip/250409-upgrade-df-46

Conversation

@phillipleblanc
Copy link
Copy Markdown
Collaborator

No description provided.

@phillipleblanc phillipleblanc self-assigned this Apr 10, 2025
@phillipleblanc phillipleblanc requested a review from Copilot April 10, 2025 01:29
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

core/tests/integration.rs:5

  • Ensure that gating the duckdb tests with both 'duckdb' and 'federation' features is intentional, as this change may prevent tests from running in configurations where only 'duckdb' is enabled.
#[cfg(all(feature = "duckdb", feature = "federation"))]

core/src/flight/exec.rs:199

  • Verify that switching from last() to next_back() produces the intended error selection behavior, as the ordering between these methods might differ when multiple errors are present.
let err = errors.into_iter().next_back().unwrap_or_else(|| {

core/src/duckdb.rs:788

  • Confirm that 'table_name' is already of the required type for CreateExternalTable; if not, the removal of '.into()' could lead to type mismatch issues in the future.
name: table_name,

@phillipleblanc phillipleblanc merged commit 3769a58 into main Apr 10, 2025
3 checks passed
@phillipleblanc phillipleblanc deleted the phillip/250409-upgrade-df-46 branch April 10, 2025 01:31
@phillipleblanc phillipleblanc added this to the v0.4.0 milestone Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants