feat: Add Oracle table provider with rust-oracle driver #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banickn
force-pushed
the
feat/oracle-support
branch
from
22019fb to
2c1b888
Compare
Implement Oracle support using rust-oracle (ODPI-C) and bb8 connection pooling. Includes comprehensive type mappings (NUMBER, DATE, TIMESTAMP, CLOB, BLOB, RAW), schema inference, and 12 integration tests. Tested against Oracle Database 23c Free. Note: This is my first contribution to the project. Feedback welcome! :)
banickn
force-pushed
the
feat/oracle-support
branch
from
f653c95 to
84972c8
Compare
Collaborator
|
@banickn thank you! We actually already have a Oracle table provider in Spice (https://github.com/spiceai/spiceai/tree/trunk/crates/data_components/src/oracle). You may want to compare the implementations, and we'd be happy to contribute this too. |
Author
|
I wasn't aware of the spice.ai oracle table provider. Just for clarification, your suggestion is that I should implement the improvements from spice.ai to this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Oracle support using rust-oracle (ODPI-C) and bb8 connection pooling. Includes comprehensive type mappings (NUMBER, DATE, TIMESTAMP, CLOB, BLOB, RAW), schema inference, and 12 integration tests.
Tested against Oracle Database 23c Free.
Note: This is my first contribution to the project. Feedback welcome! :)