Bump spiceai duckdb-rs fork to 7648ff8c (vendored vss; fix Windows build)#660
Merged
Merged
Conversation
…ild) Updates the duckdb-rs pin from b1cf1723 to 7648ff8c — spiceai/duckdb-rs#39, which vendors the vss extension as committed files instead of a git submodule. Cargo recursively checks out submodules of this git dependency, and the previous vss submodule pulled in duckdb-vss's nested duckdb checkout, whose deep path exceeded Windows' MAX_PATH and broke the Windows build. No DuckDB Rust API change; lock updated for the new rev only.
phillipleblanc
added a commit
to spiceai/spiceai
that referenced
this pull request
Jun 3, 2026
Bump duckdb-rs b1cf1723 -> 7648ff8c (spiceai/duckdb-rs#39) and datafusion-table-providers be0837e3 -> 4af85422 (datafusion-contrib/datafusion-table-providers#660). Those vendor the vss extension as committed files instead of a git submodule. The vss submodule dragged in duckdb-vss's own nested `duckdb` submodule via Cargo's recursive submodule checkout of the duckdb-rs git dependency, and that nested checkout's deep Swift example path exceeded Windows' MAX_PATH, breaking the Windows build. Vendored sources have no submodules to recurse into. No functional change to the bundled DuckDB (same v1.5.3 + statically-linked vss).
phillipleblanc
added a commit
to spiceai/spiceai
that referenced
this pull request
Jun 3, 2026
…mongodb API Bump duckdb-rs b1cf1723 -> 7648ff8c (spiceai/duckdb-rs#39) and datafusion-table-providers be0837e3 -> 4af85422 (datafusion-contrib/datafusion-table-providers#660). Those vendor the vss extension as committed files instead of a git submodule, fixing the Windows MAX_PATH break (Cargo recursively checked out the vss submodule's nested duckdb, whose deep Swift path exceeded Windows' MAX_PATH). The table-providers bump to the current spiceai-52 head also brings in #657 (mongodb schema merging), which added an optional declared-schema arg to MongoDBTableFactory::table_provider. Adapt crates/data_components/src/mongodb.rs to pass None (no declared schema at that layer). No functional change to the bundled DuckDB (same v1.5.3 + statically-linked vss).
phillipleblanc
added a commit
to spiceai/spiceai
that referenced
this pull request
Jun 3, 2026
…mongodb API (#11140) Bump duckdb-rs b1cf1723 -> 7648ff8c (spiceai/duckdb-rs#39) and datafusion-table-providers be0837e3 -> 4af85422 (datafusion-contrib/datafusion-table-providers#660). Those vendor the vss extension as committed files instead of a git submodule, fixing the Windows MAX_PATH break (Cargo recursively checked out the vss submodule's nested duckdb, whose deep Swift path exceeded Windows' MAX_PATH). The table-providers bump to the current spiceai-52 head also brings in #657 (mongodb schema merging), which added an optional declared-schema arg to MongoDBTableFactory::table_provider. Adapt crates/data_components/src/mongodb.rs to pass None (no declared schema at that layer). No functional change to the bundled DuckDB (same v1.5.3 + statically-linked vss).
phillipleblanc
added a commit
to spiceai/spiceai
that referenced
this pull request
Jun 3, 2026
…mongodb API (#11140) Bump duckdb-rs b1cf1723 -> 7648ff8c (spiceai/duckdb-rs#39) and datafusion-table-providers be0837e3 -> 4af85422 (datafusion-contrib/datafusion-table-providers#660). Those vendor the vss extension as committed files instead of a git submodule, fixing the Windows MAX_PATH break (Cargo recursively checked out the vss submodule's nested duckdb, whose deep Swift path exceeded Windows' MAX_PATH). The table-providers bump to the current spiceai-52 head also brings in #657 (mongodb schema merging), which added an optional declared-schema arg to MongoDBTableFactory::table_provider. Adapt crates/data_components/src/mongodb.rs to pass None (no declared schema at that layer). No functional change to the bundled DuckDB (same v1.5.3 + statically-linked vss).
github-actions Bot
pushed a commit
to spiceai/spiceai
that referenced
this pull request
Jun 6, 2026
…mongodb API (#11140) Bump duckdb-rs b1cf1723 -> 7648ff8c (spiceai/duckdb-rs#39) and datafusion-table-providers be0837e3 -> 4af85422 (datafusion-contrib/datafusion-table-providers#660). Those vendor the vss extension as committed files instead of a git submodule, fixing the Windows MAX_PATH break (Cargo recursively checked out the vss submodule's nested duckdb, whose deep Swift path exceeded Windows' MAX_PATH). The table-providers bump to the current spiceai-52 head also brings in #657 (mongodb schema merging), which added an optional declared-schema arg to MongoDBTableFactory::table_provider. Adapt crates/data_components/src/mongodb.rs to pass None (no declared schema at that layer). No functional change to the bundled DuckDB (same v1.5.3 + statically-linked vss).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
duckdb(spiceai duckdb-rs fork) pin fromb1cf1723to7648ff8c— the head ofspiceai/duckdb-rsspiceai-1.5.3after spiceai/duckdb-rs#39, which vendors the VSS extension as committed files instead of a git submodule.Why
Cargo recursively checks out all submodules of this git dependency. The previous vss submodule dragged in duckdb-vss's own nested
duckdbsubmodule, whose deeply-nested Swift example path exceeds Windows'MAX_PATH— breaking the Windows build. Vendoring the vss source as files removes all submodules from the dependency.Change
Cargo.toml:duckdbrevb1cf1723->7648ff8c.Cargo.lock: the twoduckdb/libduckdb-sysgit source entries updated to the new rev (source-string only; no DuckDB Rust API change between the revs).Validation
cargo metadata --lockedresolves cleanly. Keeps table-providers' duckdb in sync with consumers that pin the same rev (avoids duplicatelibduckdb-sys/links = "duckdb").