Skip to content

Add variant_contains UDF#59

Merged
friendlymatthew merged 5 commits into
datafusion-contrib:mainfrom
getChan:variant-contains-issue-50
May 18, 2026
Merged

Add variant_contains UDF#59
friendlymatthew merged 5 commits into
datafusion-contrib:mainfrom
getChan:variant-contains-issue-50

Conversation

@getChan
Copy link
Copy Markdown
Contributor

@getChan getChan commented Apr 11, 2026

Summary

  • add initial variant_contains UDF implementation
  • register the new UDF in the CLI example and sqllogictest harness
  • add sqllogictests covering nested paths, array indexes, and null variant rows

Notes

  • NULL path arguments return an execution error: path argument must be non-null

Closes #50

Copy link
Copy Markdown
Member

@friendlymatthew friendlymatthew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @getChan this looks great to me and welcome aboard 🚀

One small comment about the gitignore

Comment thread .gitignore Outdated
Copilot AI and others added 2 commits April 17, 2026 03:32
Agent-Logs-Url: https://github.com/getChan/datafusion-variant/sessions/4c154f78-d449-4fc1-b0da-6c643e55e364

Co-authored-by: getChan <33323415+getChan@users.noreply.github.com>
Remove IntelliJ `.idea` from repository ignore rules
@getChan
Copy link
Copy Markdown
Contributor Author

getChan commented May 18, 2026

@friendlymatthew thanks for review.
If this project is still active, would it be possible to get this merge? After the merge, I'd like to look into further contributions I can make.

@friendlymatthew
Copy link
Copy Markdown
Member

@getChan

Hi yes, I was on vacation the past 2 weeks and just got back

Thank you for your contribution and welcome

@friendlymatthew friendlymatthew merged commit 92eb5a3 into datafusion-contrib:main May 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

variant_contains: initial implementation

3 participants