feat: disable datafusion's default features#49
Conversation
kylebarron
left a comment
There was a problem hiding this comment.
Thanks!
Tests in
/pythonappear to succeed, but there aren't a lot.
The top-level Cargo.toml for the Python bindings is here, so this PR doesn't currently change the fact that the Python bindings include DataFusion's default features:
geodatafusion/python/Cargo.toml
Lines 21 to 22 in 79710d3
|
I had a look at https://github.com/datafusion-contrib/datafusion-table-providers/blob/main/python/Cargo.toml as a reference, and there it uses the workspace-defined dependency with default features disabled. Should I disable the default feature for the Python bindings as well? |
|
In that case, I don't see why not; might as well try setting default features off and see if it works |
|
Thanks |
Closes #48
This disables DataFusion's default features and thus allows downstream users to select which default features in
datafusionare enabled in their builds.Tests in
/pythonappear to succeed, but there aren't a lot. I am also not very familiar with py3 bindings and not sure if all features should be enabled for the python crate.I haven't checked other dependencies for their default features.
geoseems to have multiple default features, one which pulls inrayon, so it might be another candidate fordefault-features = false.