Skip to content

feat: disable datafusion's default features#49

Merged
kylebarron merged 2 commits into
datafusion-contrib:mainfrom
valkum:disable-default-features
Dec 2, 2025
Merged

feat: disable datafusion's default features#49
kylebarron merged 2 commits into
datafusion-contrib:mainfrom
valkum:disable-default-features

Conversation

@valkum

@valkum valkum commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

Closes #48

This disables DataFusion's default features and thus allows downstream users to select which default features in datafusion are enabled in their builds.

Tests in /python appear to succeed, but there aren't a lot. I am also not very familiar with py3 bindings and not sure if all features should be enabled for the python crate.

I haven't checked other dependencies for their default features. geo seems to have multiple default features, one which pulls in rayon, so it might be another candidate for default-features = false.

@github-actions github-actions Bot added the feat label Dec 1, 2025

@kylebarron kylebarron left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Tests in /python appear to succeed, but there aren't a lot.

The top-level Cargo.toml for the Python bindings is here, so this PR doesn't currently change the fact that the Python bindings include DataFusion's default features:

datafusion = "50.2"
datafusion-ffi = "50.2"

@valkum

valkum commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

I had a look at https://github.com/datafusion-contrib/datafusion-table-providers/blob/main/python/Cargo.toml as a reference, and there it uses the workspace-defined dependency with default features disabled. Should I disable the default feature for the Python bindings as well?

@kylebarron

Copy link
Copy Markdown
Collaborator

In that case, I don't see why not; might as well try setting default features off and see if it works

@kylebarron

Copy link
Copy Markdown
Collaborator

Thanks

@kylebarron kylebarron merged commit 5bb2895 into datafusion-contrib:main Dec 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

geodatafusion should use datafusion with the minimal set of needed features enabled

2 participants