feat: ST_IsClosed#69
Merged
Merged
Conversation
refactor: update ST_IsClosed implementation and add tests refactor: update ST_IsClosed tests with comprehensive cases chore: fixed format on is_closed.rs feat: add ST_IsClosed to Python bindings and update tests chore: fix formatting refactor: move ST_IsClosed to validation module refactor: move IsClosed from measurement to validation refactor: update error with IsClosed UDF refactor: add pytest validation test for ST_IsClosed UDF
Collaborator
|
Thanks for the PR!
Would you be able to move this to "geometry accessors" I intended to make the layout parallel to the sections in the PostGIS reference 
|
Collaborator
|
So I think it could go in this folder: https://github.com/datafusion-contrib/geodatafusion/tree/main/rust/geodatafusion/src/udf/native/accessors |
Contributor
Author
|
Thank you for reviewing! Ahh ok, that makes sense, I'll work on moving the code and will update the PR once I've got it completed! |
kylebarron
approved these changes
Apr 24, 2026
Collaborator
kylebarron
left a comment
kylebarron
left a comment
There was a problem hiding this comment.
looks good to me, thanks!
Contributor
Author
|
Awesome! Thanks again for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements the
ST_IsClosedspatial function. I added this to theValidation functionsbut if this should be housed elsewhere just let me know!Change List
ST_IsClosedUDF implementation inrust/geodatafusion/src/udf/geo/validation/is_closed.rsTest Coverage
Added a test suite in
is_closed.rscovering:LineStrings.MultiLineStringswith mixed closure statuses.Points,Polygons).Linting
Ran
cargo clippy --all-features --tests -- -D warningsRunning Tests
Ran
cargo test --all-featuresDocumentation
Ran
cargo doc --all-features --open