fix: list(None) is logically equivalent to list("/")#19
Merged
Conversation
Sending minidfs a list operation of an empty string does not appear to
be valid, added a regression test here too.
---- test::test_object_store stdout ----
thread 'test::test_object_store' panicked at tests/test_object_store.rs:86:37:
called `Result::unwrap()` on an `Err` value: Generic { store: "HdfsObjectStore", source: RPCError("java.lang.AssertionError", "Absolute path required, but got ''\n\tat org.apache.hadoop.hdfs.server.namenode.INode.checkAbsolutePath(INode.java:849)\n\tat org.apache.hadoop.hdfs.server.namenode.INode.getPathComponents(INode.java:824)\n\tat org.apache.hadoop.hdfs.server.namenode.FSDirectory.resolvePath(FSDirectory.java:726)\n\tat org.apache.hadoop.hdfs.server.namenode.FSDirStatAndListingOp.getListingInt(FSDirStatAndListingOp.java:57)\n\tat org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getListing(FSNamesystem.java:4200)\n\tat org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.getListing(NameNodeRpcServer.java:1195)\n\tat org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.getListing(ClientNamenodeProtocolServerSideTranslatorPB.java:762)\n\tat org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)\n\tat org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:621)\n\tat org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:589)\n\tat org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:573)\n\tat org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1227)\n\tat org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1246)\n\tat org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1169)\n\tat java.base/java.security.AccessController.doPrivileged(Native Method)\n\tat java.base/javax.security.auth.Subject.doAs(Subject.java:423)\n\tat org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1953)\n\tat org.apache.hadoop.ipc.Server$Handler.run(Server.java:3198)\n") }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Dropping and killing minidfs
Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
Collaborator
|
Just let me know if/when you need a release cut |
Contributor
Author
|
@Kimahriman whenever you have time is fine, this behavior causes trouble in delta-kernel-rs. I discovered our integration tests weren't actually running in CI for HDFS 🤦 |
Collaborator
Hah awesome. If this was the only issue you hit I can make the release |
Kimahriman
pushed a commit
that referenced
this pull request
May 13, 2025
Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
Contributor
Author
|
if you wouldn't mind cutting that release, then I can move forward with the enabling of the hdfs integration tests for for kernel |
Collaborator
Done |
hamidgh09
referenced
this pull request
in logicalclocks/hopsfs-native-object-store
Feb 2, 2026
Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending minidfs a list operation of an empty string does not appear to be valid, added a regression test here too.