Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use APIv2 for datasets #369

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/Datasets/AdminUpdateDatasetPage.vue
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@

<script setup lang="ts">
import { BrandedButton } from '@datagouv/components-next'
import type { Dataset, Frequency, License } from '@datagouv/components-next'
import type { DatasetV2, Frequency, License } from '@datagouv/components-next'
import { RiArchiveLine, RiDeleteBin6Line } from '@remixicon/vue'
import DescribeDataset from '~/components/Datasets/DescribeDataset.vue'
import type { DatasetForm, EnrichedLicense, SpatialGranularity } from '~/types/types'
Expand Down Expand Up @@ -112,8 +112,8 @@ const licenses = computed(() => {
})
const { data: granularities } = await useAPI<Array<SpatialGranularity>>('/api/1/spatial/granularities/', { lazy: true })

const url = computed(() => `/api/1/datasets/${route.params.id}`)
const { data: dataset, refresh } = await useAPI<Dataset>(url)
const url = computed(() => `/api/2/datasets/${route.params.id}`)
const { data: dataset, refresh } = await useAPI<DatasetV2>(url)
const datasetForm = ref<DatasetForm | null>(null)
const harvested = ref(false)
watchEffect(() => {
Expand Down
6 changes: 3 additions & 3 deletions components/DatasetsSelect.vue
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ import SearchableSelect from '~/components/SearchableSelect.vue'
import type { DatasetSuggest } from '~/types/types'

const sortableRootRef = useTemplateRef('sortableRoot')
const datasetsById = ref<Record<string, Dataset>>({})
const datasetsById = ref<Record<string, Dataset | DatasetV2>>({})

const selectedDatasetsSuggest = defineModel<Array<Dataset | DatasetV2 | DatasetSuggest>>({ required: true })
const datasetUrl = ref('')
Expand All @@ -130,7 +130,7 @@ watchEffect(async () => {
datasetsById.value[dataset.id] = dataset
}
else {
datasetsById.value[dataset.id] = await $api<Dataset>(`/api/1/datasets/${dataset.id}/`)
datasetsById.value[dataset.id] = await $api<Dataset>(`/api/2/datasets/${dataset.id}/`)
}
}
})
Expand All @@ -149,7 +149,7 @@ const loadDatasetByLink = async () => {
}
const id = matches[1]
try {
const dataset = await $api<Dataset>(`/api/1/datasets/${id}/`)
const dataset = await $api<DatasetV2>(`/api/2/datasets/${id}/`)
if (selectedDatasetsSuggest.value.find(suggest => suggest.id === dataset.id)) {
datasetUrlError.value = t('The dataset is already present in the list.')
return
Expand Down
4 changes: 2 additions & 2 deletions design-system/BannerNotif.vue
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@
</template>

<script setup lang="ts">
import { BrandedButton, type Dataset, type User } from '@datagouv/components-next'
import { BrandedButton, type DatasetV2, type User } from '@datagouv/components-next'
import { RiCheckLine, RiCloseLine, RiSendPlaneLine } from '@remixicon/vue'

const { data: user } = await useAPI<User>(`/api/1/users/antonin-garrone`)
const { data: dataset } = await useAPI<Dataset>(`/api/1/datasets/base-sirene-des-entreprises-et-de-leurs-etablissements-siren-siret`)
const { data: dataset } = await useAPI<DatasetV2>(`/api/2/datasets/base-sirene-des-entreprises-et-de-leurs-etablissements-siren-siret`)
</script>
7 changes: 3 additions & 4 deletions pages/beta/admin/datasets/[id].vue
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,7 @@
</template>

<script setup lang="ts">
import { BrandedButton, DatasetQualityTooltipContent } from '@datagouv/components-next'
import { DatasetQualityScore, summarize, type Dataset } from '@datagouv/components-next'
import { BrandedButton, DatasetQualityTooltipContent, type DatasetV2, DatasetQualityScore, summarize } from '@datagouv/components-next'
import { RiDownloadLine, RiEyeLine, RiInformationLine, RiLineChartLine, RiPriceTag3Line } from '@remixicon/vue'
import AdminBreadcrumb from '~/components/Breadcrumbs/AdminBreadcrumb.vue'
import BreadcrumbItem from '~/components/Breadcrumbs/BreadcrumbItem.vue'
Expand All @@ -108,7 +107,7 @@ const { t } = useI18n()
const { currentOrganization } = useCurrentOwned()

const route = useRoute()
const url = computed(() => `/api/1/datasets/${route.params.id}`)
const { data: dataset } = await useAPI<Dataset>(url)
const url = computed(() => `/api/2/datasets/${route.params.id}`)
const { data: dataset } = await useAPI<DatasetV2>(url)
watchEffect(() => console.log(dataset.value))
</script>
4 changes: 2 additions & 2 deletions pages/beta/admin/datasets/[id]/discussions.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
</template>

<script setup lang="ts">
import type { Dataset } from '@datagouv/components-next'
import type { DatasetV2 } from '@datagouv/components-next'
import DiscussionsPage from '~/components/Discussions/DiscussionsPage.vue'

defineProps<{
dataset: Dataset
dataset: DatasetV2
}>()
</script>
4 changes: 2 additions & 2 deletions pages/beta/admin/datasets/[id]/files.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
</template>

<script setup lang="ts">
import type { Dataset } from '@datagouv/components-next'
import type { DatasetV2 } from '@datagouv/components-next'
import AdminDatasetResourcesPage from '~/components/Datasets/AdminDatasetResourcesPage.vue'

defineProps<{
dataset: Dataset
dataset: DatasetV2
}>()
</script>
4 changes: 2 additions & 2 deletions pages/beta/admin/datasets/[id]/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
</template>

<script setup lang="ts">
import type { Dataset } from '@datagouv/components-next'
import type { DatasetV2 } from '@datagouv/components-next'
import AdminUpdateDatasetPage from '~/components/Datasets/AdminUpdateDatasetPage.vue'

defineProps<{
dataset: Dataset
dataset: DatasetV2
}>()
</script>
4 changes: 2 additions & 2 deletions pages/design.vue
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
</template>

<script setup lang="ts">
import { DatasetCard, DatasetQuality, ReadMore, ResourceAccordion, SimpleBanner, type Dataset } from '@datagouv/components-next'
import { DatasetCard, DatasetQuality, ReadMore, ResourceAccordion, SimpleBanner, type DatasetV2 } from '@datagouv/components-next'
import DatasetSearchPage from '~/components/Datasets/SearchPage.vue'
import AdminBadge from '~/design-system/AdminBadge.vue'
import BannerAction from '~/design-system/BannerAction.vue'
Expand All @@ -120,5 +120,5 @@ import BrandedButton from '~/design-system/BrandedButton.vue'
import OrganizationNameWithCertificate from '~/design-system/OrganizationNameWithCertificate.vue'
import SearchInput from '~/design-system/SearchInput.vue'

const { data: dataset } = await useAPI<Dataset>('/api/1/datasets/repertoire-national-des-elus-1')
const { data: dataset } = await useAPI<DatasetV2>('/api/2/datasets/repertoire-national-des-elus-1')
</script>
4 changes: 2 additions & 2 deletions types/discussions.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Dataservice, Dataset, Reuse, User } from '@datagouv/components-next'
import type { Dataservice, Dataset, DatasetV2, Reuse, User } from '@datagouv/components-next'
import type { Post } from './posts'

export type DiscussionSortedBy = 'title' | 'created' | 'closed'
Expand All @@ -16,7 +16,7 @@ export type Comment = { content: string, posted_by: User, posted_on: string, spa

export type Discussion = Array<Comment>

export type DiscussionSubjectTypes = Dataservice | Dataset | Reuse | Post
export type DiscussionSubjectTypes = Dataservice | Dataset | DatasetV2 | Reuse | Post

export type DiscussionSubject = {
class: 'Dataservice' | 'Dataset' | 'Reuse' | 'Post' | 'Topic' | 'Organization'
Expand Down
2 changes: 1 addition & 1 deletion utils/datasets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export function getDatasetAdminUrl(dataset: Dataset | DatasetV2): string {
return `/beta/admin/datasets/${dataset.id}`
}

export function toForm(dataset: Dataset, licenses: Array<License>, frequencies: Array<Frequency>, zones: Array<SpatialZone>, granularities: Array<SpatialGranularity>): DatasetForm {
export function toForm(dataset: Dataset | DatasetV2, licenses: Array<License>, frequencies: Array<Frequency>, zones: Array<SpatialZone>, granularities: Array<SpatialGranularity>): DatasetForm {
return {
owned: dataset.organization ? { organization: dataset.organization, owner: null } : { owner: dataset.owner, organization: null },
title: dataset.title,
Expand Down
4 changes: 2 additions & 2 deletions utils/discussions.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Dataservice, Dataset, Reuse } from '@datagouv/components-next'
import type { Dataservice, DatasetV2, Reuse } from '@datagouv/components-next'
import { RiArticleLine, RiDatabase2Line, RiLineChartLine, RiTerminalLine } from '@remixicon/vue'
import type { $Fetch } from 'ofetch'
import type { DiscussionSubject, DiscussionSubjectTypes } from '~/types/discussions'
Expand All @@ -8,7 +8,7 @@ export async function getSubject(api: $Fetch, subject: DiscussionSubject): Promi
case 'Dataservice':
return await api<Dataservice>(`/api/1/dataservices/${subject.id}`)
case 'Dataset':
return await api<Dataset>(`/api/1/datasets/${subject.id}`)
return await api<DatasetV2>(`/api/2/datasets/${subject.id}`)
case 'Reuse':
return await api<Reuse>(`/api/1/reuses/${subject.id}`)
default:
Expand Down