-
Notifications
You must be signed in to change notification settings - Fork 3
feat(harvest): show organization for which the user is admin only in producer select #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maudetes
wants to merge
58
commits into
main
Choose a base branch
from
feat/producer-select-for-org-and-admin-only-for-harvest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
66170c3
add: publier.etalab.studio into admin
geoffreyaldebert 9537255
feat: not only tableschema
geoffreyaldebert 2ed1e8c
feat: optional param in url to auto select schema
geoffreyaldebert 7e4a95a
feat: allow producerselect component to propose or not user
geoffreyaldebert b0d4a34
feat: add paddedcontainer if no organisation for producerselect
geoffreyaldebert 8f5efc2
feat: better visualization of schema cards and selection
geoffreyaldebert b86fccb
feat: do not propose to modify resource card when tableschema
geoffreyaldebert 6c2444f
style: table
geoffreyaldebert 1c1ba54
feat: do not propose to go next when table is not validated
geoffreyaldebert 3701ba8
fixes
geoffreyaldebert 01caf83
Merge branch 'main' into publier-schema
nicolaskempf57 7620690
Merge branch 'main' into publier-schema
nicolaskempf57 a902656
Merge branch 'main' into publier-schema
maudetes d383ecb
Fix package.json & lock
maudetes 708dab3
Fix PaddedContainer import
maudetes 1bf8c9c
Use useTranslation instead of useI18n
maudetes 7f9666b
fix: after merge missing testid
nicolaskempf57 02c49d6
refac: use href and tailwind classes
nicolaskempf57 feec735
refac: update schema types
nicolaskempf57 38b36c8
refac: remove unnecessary externals
nicolaskempf57 85dafae
fix: step 1 and move to FormWithAccordions
nicolaskempf57 c10550f
fix: dataset search outside of schema
nicolaskempf57 98f5309
refac: improve schema search UX
nicolaskempf57 e05ad41
refac: fix type
nicolaskempf57 6e7d418
refac: use tailwindcss classes
nicolaskempf57 c8b7319
fix: import
nicolaskempf57 d1bf158
refac: remove some states
nicolaskempf57 7c49bbe
refac: remove duplicated states
nicolaskempf57 0511052
refac: remove states and simplify
nicolaskempf57 d4da863
feat: update popup
nicolaskempf57 85b33e4
feat: improves based on issue comments
nicolaskempf57 dc0364f
refac: use Banner instead of Alert
nicolaskempf57 492bf0c
Merge branch 'main' into publier-schema
nicolaskempf57 b94876e
fix(schema): redesign SchemaCard
nicolaskempf57 4851d3e
feat: add schema card on step 2
nicolaskempf57 5e7b78e
refactor(schema): add tabular editor component with CSV parsing
nicolaskempf57 b819d71
fix(DatasetsSelect): prevent card overflow with min-w-0
nicolaskempf57 47e384a
refactor(TabularEditor): use icon props and remove debug logs
nicolaskempf57 20fd2e0
refactor(Step3): use v-model instead of useState
nicolaskempf57 ab2c2d8
refactor(structured): improve data flow and UX
nicolaskempf57 6ba284c
fix(strutured): new dataset saved as user one
nicolaskempf57 16b9a37
fix(structured): correct redirect after step 4
nicolaskempf57 5d675cd
Merge branch 'main' into publier-schema
maudetes fd3b53a
Merge branch 'main' into publier-schema
maudetes 887707f
feat: add feature flag for structured dataset form
nicolaskempf57 20962c2
chore: lock updates
nicolaskempf57 0afb011
chore: another lock changes
nicolaskempf57 fb38297
Merge branch 'main' into publier-schema
nicolaskempf57 45d0cd3
fix: types
nicolaskempf57 6475a56
feat(harvest): show organization for which the user is admin only in …
maudetes e341246
Simplify useAPI organization url
maudetes c1cefa4
Use harvester illustration
maudetes 9fa91bb
Merge branch 'main' into feat/producer-select-for-org-and-admin-only-…
maudetes 5d681e9
Use isUserOrgAdmin util and remove redirectOn404
maudetes a45f381
Fix isOrgAdmin in harvester configuration
maudetes cbc1e59
Merge branch 'main' into feat/producer-select-for-org-and-admin-only-…
maudetes f05fa90
organization may be null
maudetes 4d19110
Merge branch 'main' into feat/producer-select-for-org-and-admin-only-…
maudetes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any more straightforward way to know organizations for which the user is admin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The computed code can be simplified when this one is merged https://github.com/datagouv/cdata/pull/790/files.
But if we don't want to query all organizations, I think members should be added to the
api/1/meUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say it seems overkill to get the entire organization members on
api/1/mefor now!We may change it if we have other use cases than harvest publication form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we expose a permission field instead ? Like the one in the dataservice model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think it's better to expose a permission field…