Skip to content

Conversation

@Pierlou
Copy link
Contributor

@Pierlou Pierlou commented Dec 9, 2025

Get rid of bumpx and use the same script as for our other repos

Copy link
Contributor

@bolinocroustibat bolinocroustibat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this to work I think we also need to:

  • remove the hardcoded version key/value in pyproject.toml
  • replace it with a dynamic = ["version"] key
  • add setuptools_scm into build-system->requires
  • add the setuptools_scm config to auto-guess the next version:
[tool.setuptools_scm]
version_scheme = "guess-next-dev"
local_scheme = "no-local-version"

Like here

(unless we do a in-between solution like we do with csv detective using a custom script)

@Pierlou Do you want me to commit this changes to this PR?

@bolinocroustibat
Copy link
Contributor

bolinocroustibat commented Dec 10, 2025

For this to work I think we also need to:

  • remove the hardcoded version key/value in pyproject.toml
  • replace it with a dynamic = ["version"] key
  • add setuptools_scm into build-system->requires
  • add the setuptools_scm config to auto-guess the next version:
[tool.setuptools_scm]
version_scheme = "guess-next-dev"
local_scheme = "no-local-version"

Like here

(unless we do a in-between solution like we do with csv detective using a custom script)

@Pierlou Do you want me to commit this changes to this PR?

Oh sorry my bad I just realized there is a custom script update_version.sh in the repo like in csv-detective, to update the version in pyproject.toml, so your PR should work indeed!
Except if we want to fully move to a dynamic version in the same PR, or we can do that in two steps indeed.

@Pierlou
Copy link
Contributor Author

Pierlou commented Dec 11, 2025

Hmm idk if we want to go for an in-between again, maybe we should migrate completely as you suggest?

@bolinocroustibat
Copy link
Contributor

Hmm idk if we want to go for an in-between again, maybe we should migrate completely as you suggest?

I'm ok with going all the way. Shall I commit the changes myself on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants