fix: verify allowlist tx receipt status in e2e validator helper#454
Open
vikions wants to merge 4 commits intodatahaven-xyz:mainfrom
Open
fix: verify allowlist tx receipt status in e2e validator helper#454vikions wants to merge 4 commits intodatahaven-xyz:mainfrom
vikions wants to merge 4 commits intodatahaven-xyz:mainfrom
Conversation
Contributor
|
Thanks for your contribution @vikions ! |
Author
The docker CI fails because this PR comes from a fork, and GitHub doesn’t allow pushing images to the org’s GHCR from fork PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addValidatorToAllowlistin the E2E validator helper was awaitingwaitForTransactionReceiptbut discarding the result entirely.This means a reverted transaction would still be treated as a
successful allowlist operation — the test would continue without
any indication that the on-chain call failed.
This patch captures the receipt and explicitly checks its status,
throwing a descriptive error if the transaction did not succeed.
This prevents false-positive test results when the allowlist tx reverts.
Changes
test/e2e/framework/validators.ts: capture receipt fromwaitForTransactionReceiptand assertstatus === "success"Test plan
rather than passing silently