Skip to content

fix: verify allowlist tx receipt status in e2e validator helper#454

Open
vikions wants to merge 4 commits intodatahaven-xyz:mainfrom
vikions:fix/verify-allowlist-tx-receipt-status
Open

fix: verify allowlist tx receipt status in e2e validator helper#454
vikions wants to merge 4 commits intodatahaven-xyz:mainfrom
vikions:fix/verify-allowlist-tx-receipt-status

Conversation

@vikions
Copy link
Copy Markdown

@vikions vikions commented Feb 23, 2026

Summary

addValidatorToAllowlist in the E2E validator helper was awaiting
waitForTransactionReceipt but discarding the result entirely.
This means a reverted transaction would still be treated as a
successful allowlist operation — the test would continue without
any indication that the on-chain call failed.

This patch captures the receipt and explicitly checks its status,
throwing a descriptive error if the transaction did not succeed.
This prevents false-positive test results when the allowlist tx reverts.

Changes

  • test/e2e/framework/validators.ts: capture receipt from
    waitForTransactionReceipt and assert status === "success"

Test plan

  • Existing E2E validator test suites exercise this code path
  • A reverted allowlist tx will now surface as an explicit failure
    rather than passing silently

@vikions vikions requested review from a team as code owners February 23, 2026 17:16
@stiiifff
Copy link
Copy Markdown
Contributor

Thanks for your contribution @vikions !

@stiiifff stiiifff added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes labels Feb 24, 2026
@vikions
Copy link
Copy Markdown
Author

vikions commented Feb 26, 2026

Thanks for your contribution @vikions !

The docker CI fails because this PR comes from a fork, and GitHub doesn’t allow pushing images to the org’s GHCR from fork PRs.
Maybe we can skip --push on pull_request and only push on main (or tags)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants