Skip to content

Conversation

sakethvarma397
Copy link
Contributor

@sakethvarma397 sakethvarma397 commented Oct 10, 2025

Currently, the only way to see all the views in the instance is via the Views bar next to the Search. In the Manage Views page the users can only see the views created by themselves and not the public views.
This would be confusing to users (especially admins and other with manage_global_views permission) who'd want to manage all the views available in the instance.
Adding this new tab under views page can resolve that confusion. If they have the permissions they can edit these public views, otherwise they can just preview them.

Before:
Screenshot 2025-09-22 at 5 30 47 PM

After:
Screenshot 2025-09-23 at 5 21 38 PM
Screenshot 2025-10-10 at 3 28 32 PM

Notes:

  • The 'My Views' section under Settings is renamed to just 'Views' as they can see all views here. Even the header "Manage Views' is changed to just 'Views'. Can revert these if needed.
  • The click on View name currently opens the Edit View modal.. which is confusing and not consistent with tables in the app. Removed that functionality now. The users can simply use the actions dropdown.
  • Tested responsiveness with different scenarios

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests labels Oct 10, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 10, 2025
Copy link

codecov bot commented Oct 10, 2025

Bundle Report

Changes will increase total bundle size by 5.4kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.59MB 5.4kB (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 5.4kB 18.94MB 0.03%

Files in assets/index-*.js:

  • ./src/app/settingsV2/SettingsPage.tsx → Total Size: 7.91kB

  • ./src/app/entityV2/view/ViewTypeLabel.tsx → Total Size: 1.05kB

  • ./src/app/entityV2/view/select/ViewsTableColumns.tsx → Total Size: 1.69kB

  • ./src/app/entityV2/view/ViewsTable.tsx → Total Size: 1.29kB

  • ./src/app/entityV2/view/ViewsList.tsx → Total Size: 3.73kB

  • ./src/app/settingsV2/settingsPaths.tsx → Total Size: 897 bytes

  • ./src/app/entityV2/view/ManageViews.tsx → Total Size: 3.15kB

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant