feat(mssql): auto-enable use_odbc when source type is mssql-odbc #15702
+122
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When users configure the source type as
mssql-odbc, they currently also need to manually setuse_odbc: truein their recipe config. This is redundant and confusing - the source type name already implies ODBC should be used.This PR automatically enables
use_odbcwhen the source type ismssql-odbc, eliminating the need for redundant configuration.Changes
SQLServerSource.create()**: When source type ismssql-odbcanduse_odbcis not explicitly set, automatically set it toTrueuse_odbc: "True"from the ODBC example recipeuse_odbc: truefrom test configmssql-odbctypepipeline_configis NoneTest Plan
mssql-odbcsource type