Skip to content

Conversation

@alfiyas-datahub
Copy link
Contributor

Summary

When users configure the source type as mssql-odbc, they currently also need to manually set use_odbc: true in their recipe config. This is redundant and confusing - the source type name already implies ODBC should be used.

This PR automatically enables use_odbc when the source type is mssql-odbc, eliminating the need for redundant configuration.

Changes

  • Auto-detection in SQLServerSource.create()**: When source type is mssql-odbc and use_odbc is not explicitly set, automatically set it to True
  • Updated recipe docs**: Removed unnecessary use_odbc: "True" from the ODBC example recipe
  • Updated integration test**: Removed redundant use_odbc: true from test config
  • Added unit tests**: Comprehensive tests covering:
  • Auto-enabling for mssql-odbc type
  • Handling when pipeline_config is None

Test Plan

  • Added unit tests for all scenarios
  • Existing integration tests pass
  • Manual verification with mssql-odbc source type

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Dec 17, 2025
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Dec 17, 2025

✅ Meticulous spotted 0 visual differences across 984 screens tested: view results.

Meticulous evaluated ~8 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit b04841c. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Dec 17, 2025

Bundle Report

Bundle size has no change ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants