Skip to content

Conversation

@asikowitz
Copy link
Collaborator

Nodes and edges are primarily managed by two hooks in LineageDisplay. We need to move the addAnnotationNodes logic there, or refactor those hooks into here. I believe I put it into LineageDisplay so I could make this a memoized component.

By setting nodes and edges, we get rid of that management. This needs to be initialNodes and initialEdges

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Dec 17, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 17, 2025
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Dec 17, 2025

✅ Meticulous spotted 0 visual differences across 998 screens tested: view results.

Meticulous evaluated ~9 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit 3ccb90f. This comment will update as new commits are pushed.

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 17, 2025
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Dec 18, 2025

Bundle Report

Changes will increase total bundle size by 14 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 31.27MB 14 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 14 bytes 19.24MB 0.0%

Files in assets/index-*.js:

  • ./src/app/lineageV3/LineageVisualization.tsx → Total Size: 4.58kB

@github-actions github-actions bot requested a deployment to datahub-project-web-react (Preview) December 19, 2025 15:02 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants