-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix(ui/lineageV3): Fix lineage graph (breaks lineage module) #15715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
✅ Meticulous spotted 0 visual differences across 998 screens tested: view results. Meticulous evaluated ~9 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 3ccb90f. This comment will update as new commits are pushed. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Bundle ReportChanges will increase total bundle size by 14 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Nodes and edges are primarily managed by two hooks in LineageDisplay. We need to move the
addAnnotationNodeslogic there, or refactor those hooks into here. I believe I put it into LineageDisplay so I could make this a memoized component.By setting nodes and edges, we get rid of that management. This needs to be initialNodes and initialEdges