feat(secret): add SecretService caller guard with ENFORCE default#17995
Open
david-leifker wants to merge 1 commit into
Open
feat(secret): add SecretService caller guard with ENFORCE default#17995david-leifker wants to merge 1 commit into
david-leifker wants to merge 1 commit into
Conversation
github-actions
Bot
added
docs
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
david-leifker
force-pushed
the
feat/secret-service-caller-guard-enforce
branch
from
b4eb5db to
5b84e8c
Compare
Add caller guard modes (ENFORCE, AUDIT, DISABLED) to SecretService, thread OperationContext through encrypt/decrypt call sites, and default SECRET_SERVICE_CALLER_GUARD_MODE to ENFORCE. Document secure-by-default secret handling for OSS datahub-actions and Cloud embedded executors. Co-authored-by: Cursor <cursoragent@cursor.com>
david-leifker
force-pushed
the
feat/secret-service-caller-guard-enforce
branch
from
5b84e8c to
720546b
Compare
maggiehays
added
the
needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add caller guard modes (ENFORCE, AUDIT, DISABLED) to SecretService, thread OperationContext through encrypt/decrypt call sites, and default SECRET_SERVICE_CALLER_GUARD_MODE to ENFORCE. Document secure-by-default secret handling for OSS datahub-actions and Cloud embedded executors.