-
Notifications
You must be signed in to change notification settings - Fork 7
fix: add new attribute to track pose estimation files, update logic in two schemas, refactor & code cleanup #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…r plots and add `QA` dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds pose_estimation_path attribute, refactors pose/viz logic, standardizes QA directory handling, updates version/dependencies, and cleans up plotting utilities.
- Introduces pose_estimation_path to link pose estimation files directly to videos and rewrites mapping logic.
- Refactors outlier plot generation and PDF->PNG conversion; adds poppler dependency; removes fuzzy matching helpers.
- Adjusts reporting/training to search QA or quality_assurance, with stricter error handling.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Bumps project version to 1.0.3. |
| element_moseq/version.py | Syncs internal version with new release. |
| element_moseq/plotting/viz_utils.py | Removes fuzzy matching helpers; refactors outlier plot path logic; improves error handling in plotting and PDF->PNG conversion. |
| element_moseq/moseq_train.py | Uses new copy_pdf_to_png import; adds pose_estimation_path field; updates outlier plot existence checks. |
| element_moseq/moseq_report.py | Reimplements recording-to-video mapping via pose_estimation_path; changes error handling; removes recording_name field. |
| conda_env.yml | Adds poppler dependency for PDF conversion. |
| CHANGELOG.md | Adds 1.0.3 release notes. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ce) as in the latest version of kpms
…hange default behavior
This pull request updates the package to version 1.0.3 and introduces several fixes and improvements focused on pose estimation file handling, quality assurance directory logic, and code cleanup. The changes improve robustness in matching pose estimation files to videos, standardize outlier plot location logic, and simplify related code. It also adds a new system dependency and removes unused helper functions.
Pose estimation and video file handling:
pose_estimation_pathattribute to theKeypointSet.VideoFiletable, and updated related logic to use this attribute for matching pose estimation files to their corresponding videos. [1] [2]Quality assurance and outlier plot logic:
QAandquality_assurancedirectories for outlier plots, and improved error handling when plots are missing. This logic is now consistent across bothmoseq_reportandmoseq_train. [1] [2] [3]Code cleanup and refactoring:
viz_utilsmodule and refactored functions for clarity and robustness, including error handling and directory creation. [1] [2] [3] [4] [5]copy_pdf_to_pngto import directly fromviz_utils, and improved its error handling to raise exceptions instead of returning boolean values. [1] [2] [3] [4] [5]Dependency and version updates:
poppleras a system dependency inconda_env.ymlto support PDF to PNG conversion.pyproject.tomlandversion.py. [1] [2]