fix: add new attribute to track pose estimation files, update logic in two schemas, refactor & code cleanup - #22
Merged
Conversation
…r plots and add `QA` dir
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds pose_estimation_path attribute, refactors pose/viz logic, standardizes QA directory handling, updates version/dependencies, and cleans up plotting utilities.
- Introduces pose_estimation_path to link pose estimation files directly to videos and rewrites mapping logic.
- Refactors outlier plot generation and PDF->PNG conversion; adds poppler dependency; removes fuzzy matching helpers.
- Adjusts reporting/training to search QA or quality_assurance, with stricter error handling.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Bumps project version to 1.0.3. |
| element_moseq/version.py | Syncs internal version with new release. |
| element_moseq/plotting/viz_utils.py | Removes fuzzy matching helpers; refactors outlier plot path logic; improves error handling in plotting and PDF->PNG conversion. |
| element_moseq/moseq_train.py | Uses new copy_pdf_to_png import; adds pose_estimation_path field; updates outlier plot existence checks. |
| element_moseq/moseq_report.py | Reimplements recording-to-video mapping via pose_estimation_path; changes error handling; removes recording_name field. |
| conda_env.yml | Adds poppler dependency for PDF conversion. |
| CHANGELOG.md | Adds 1.0.3 release notes. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ce) as in the latest version of kpms
ttngu207
reviewed
Oct 15, 2025
ttngu207
reviewed
Oct 15, 2025
ttngu207
reviewed
Oct 15, 2025
…hange default behavior
ttngu207
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the package to version 1.0.3 and introduces several fixes and improvements focused on pose estimation file handling, quality assurance directory logic, and code cleanup. The changes improve robustness in matching pose estimation files to videos, standardize outlier plot location logic, and simplify related code. It also adds a new system dependency and removes unused helper functions.
Pose estimation and video file handling:
pose_estimation_pathattribute to theKeypointSet.VideoFiletable, and updated related logic to use this attribute for matching pose estimation files to their corresponding videos. [1] [2]Quality assurance and outlier plot logic:
QAandquality_assurancedirectories for outlier plots, and improved error handling when plots are missing. This logic is now consistent across bothmoseq_reportandmoseq_train. [1] [2] [3]Code cleanup and refactoring:
viz_utilsmodule and refactored functions for clarity and robustness, including error handling and directory creation. [1] [2] [3] [4] [5]copy_pdf_to_pngto import directly fromviz_utils, and improved its error handling to raise exceptions instead of returning boolean values. [1] [2] [3] [4] [5]Dependency and version updates:
poppleras a system dependency inconda_env.ymlto support PDF to PNG conversion.pyproject.tomlandversion.py. [1] [2]