Skip to content

Conversation

@MilagrosMarin
Copy link
Contributor

This pull request updates the package to version 1.0.3 and introduces several fixes and improvements focused on pose estimation file handling, quality assurance directory logic, and code cleanup. The changes improve robustness in matching pose estimation files to videos, standardize outlier plot location logic, and simplify related code. It also adds a new system dependency and removes unused helper functions.

Pose estimation and video file handling:

  • Added a new pose_estimation_path attribute to the KeypointSet.VideoFile table, and updated related logic to use this attribute for matching pose estimation files to their corresponding videos. [1] [2]
  • Improved logic for mapping pose estimation files to video IDs, removing the previous fuzzy matching helper and simplifying the mapping process. [1] [2]

Quality assurance and outlier plot logic:

  • Updated code to check both QA and quality_assurance directories for outlier plots, and improved error handling when plots are missing. This logic is now consistent across both moseq_report and moseq_train. [1] [2] [3]

Code cleanup and refactoring:

  • Removed unused helper functions from the viz_utils module and refactored functions for clarity and robustness, including error handling and directory creation. [1] [2] [3] [4] [5]
  • Updated usage of copy_pdf_to_png to import directly from viz_utils, and improved its error handling to raise exceptions instead of returning boolean values. [1] [2] [3] [4] [5]

Dependency and version updates:

  • Added poppler as a system dependency in conda_env.yml to support PDF to PNG conversion.
  • Bumped package version to 1.0.3 in pyproject.toml and version.py. [1] [2]

@MilagrosMarin MilagrosMarin changed the title Update docs fix: add new attribute to track pose estimation files, update logic in two schemas, refactor & code cleanup Oct 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds pose_estimation_path attribute, refactors pose/viz logic, standardizes QA directory handling, updates version/dependencies, and cleans up plotting utilities.

  • Introduces pose_estimation_path to link pose estimation files directly to videos and rewrites mapping logic.
  • Refactors outlier plot generation and PDF->PNG conversion; adds poppler dependency; removes fuzzy matching helpers.
  • Adjusts reporting/training to search QA or quality_assurance, with stricter error handling.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
pyproject.toml Bumps project version to 1.0.3.
element_moseq/version.py Syncs internal version with new release.
element_moseq/plotting/viz_utils.py Removes fuzzy matching helpers; refactors outlier plot path logic; improves error handling in plotting and PDF->PNG conversion.
element_moseq/moseq_train.py Uses new copy_pdf_to_png import; adds pose_estimation_path field; updates outlier plot existence checks.
element_moseq/moseq_report.py Reimplements recording-to-video mapping via pose_estimation_path; changes error handling; removes recording_name field.
conda_env.yml Adds poppler dependency for PDF conversion.
CHANGELOG.md Adds 1.0.3 release notes.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ttngu207 ttngu207 merged commit 5b134e8 into datajoint:main Oct 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants