-
Notifications
You must be signed in to change notification settings - Fork 16
Add support for filtering and proper pagination #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synicix
reviewed
Feb 11, 2021
Contributor
Synicix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few quick concerns, but otherwise looks good
Synicix
reviewed
Feb 11, 2021
Synicix
previously approved these changes
Feb 11, 2021
Synicix
previously approved these changes
Feb 11, 2021
727a4f6 to
17ffca3
Compare
Synicix
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example Request
GET/api/fetch_tuples?limit=1000&page=1&order=KEY+ASC&restriction=W3siYXR0cmlidXRlTmFtZSI6ICJzdHVkZW50X2Vucm9sbF9kYXRlIiwgIm9wZXJhdGlvbiI6ICI+IiwgInZhbHVlIjogIjIwMjEtMDEtMDcifSwgeyJhdHRyaWJ1dGVOYW1lIjogInN0dWRlbnRfZW5yb2xsX2RhdGUiLCAib3BlcmF0aW9uIjogIjwiLCAidmFsdWUiOiAiMjAyMS0wMS0xNyJ9XQo=Decoded
base64restriction:[ { "attributeName": "student_enroll_date", "operation": ">", "value": "2021-01-07" }, { "attributeName": "student_enroll_date", "operation": "<", "value": "2021-01-17" } ]All query parameters are optional. Defaults are as shown above with the exception of
restriction; it is simply no restriction.Example Response
total_countis also sent back now for the benefit of determining how many total pages to render on frontside.{ "total_count": 25, "tuples": [ [ 58, "Shelly Daniels", "225-02-5575", 1610755200.0, 1543.0, "LotC", 1 ], [ 29, "Ian Arroyo", "649-80-2169", 1610755200.0, 2859.0, "LotC", 1 ], [ 70, "Richard Smith", "613-80-2175", 1610755200.0, 2970.0, "LotC", 1 ], [ 72, "Julie Chen", "346-84-2037", 1610668800.0, 1642.0, "LotA", 0 ], [ 83, "Michael Mays", "127-96-0118", 1610668800.0, 2753.0, "LotB", 0 ], [ 88, "Regina Stewart", "249-31-3014", 1610668800.0, 2208.0, "LotA", 0 ], [ 75, "Richard Jones", "046-06-7966", 1610496000.0, 2616.0, "LotA", 1 ], [ 52, "Michelle Robinson", "086-48-3607", 1610496000.0, 1512.0, "LotB", 1 ], [ 6, "Rachel Garrett", "627-64-5459", 1610409600.0, 2555.0, "LotA", 0 ], [ 45, "Mrs. Jennifer Kelley", "301-15-7833", 1610409600.0, 2849.0, "LotC", 1 ] ] }Fix #48
Fix #52