Skip to content

Enhance delete to handle dependencies #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2021
Merged

Enhance delete to handle dependencies #67

merged 2 commits into from
Feb 16, 2021

Conversation

@guzman-raphael
Copy link
Collaborator

@guzman-raphael guzman-raphael commented Feb 13, 2021 •
edited
Loading

This PR serves to:

  • Fix delete so that it cascades (using newer DJ algorithm which is more performant)
  • Update version
  • Update contributor docs
  • Enable hot reload in docker-compose

@guzman-raphael guzman-raphael changed the title Update version Enhance delete to handle dependencies Feb 14, 2021
Synicix
Synicix approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@Synicix Synicix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Synicix Synicix merged commit 44de192 into datajoint:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahos mahos Awaiting requested review from mahos

1 more reviewer

@Synicix Synicix Synicix approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Alpha Release Candidate

Development

Successfully merging this pull request may close these issues.

2 participants

@guzman-raphael @Synicix