Skip to content

Conversation

@guzman-raphael
Copy link
Collaborator

@guzman-raphael guzman-raphael commented Feb 16, 2021

This PR:

  • Renames project to pharus based on Slack discussions.
  • Adds docker-compose templates for build, test, deploy.
  • Adds a changelog to capture release notes.
  • Adds continuous delivery to GH actions workflow. Logic is that on pushing tags matching *.*.*, release will be automatically triggered. Release means:
    • Manual: version.py properly updated. Should be updated via PR's and will be consumed in automating distribution artifacts.
    • Manual: CHANGELOG.md properly updated. Should be update via PR's and will be consumed in automating release notes.
    • GH Actions: Make a GH release
    • GH Actions: Generate pip artifacts (Wheel, SDist) and publish to PyPi
    • GH Actions: Generate docker images and publish to DockerHub
    • GH Actions: Upload all generated artifacts to GH release
  • Adds configuration to port with PHARUS_PORT (defaults to 5000)
  • Adds path prefix configuration with PHARUS_PREFIX (defaults to '')
  • Adds proper production-grade serve using gunicorn (default). Can serve for development using pharus (Flask builtin).
  • Removes necessity to configure HOST_UID. This is now determined in docker-compose commands.
  • Renames namespace modules in pip package to be more consistent with noun/entity common pattern.
  • Update docs and tests

@mahos @Synicix
Regarding adjustments to development going forward, the following changes will be necessary with this:

  • Rename your fork to pharus
  • Update your git remote -v references to the new repos (though the old aliases will still work for some time)
  • Review the new compose files. In particular, familiarize yourself with docker-compose-test.yaml.

@guzman-raphael guzman-raphael marked this pull request as ready for review February 16, 2021 19:10
Synicix
Synicix previously approved these changes Feb 16, 2021
Copy link
Contributor

@Synicix Synicix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

@Synicix Synicix merged commit adbd920 into datajoint:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants