feat: custom job add feature #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: changed endpoint parameter name from experiment_run_id -> model…
feat: developed function for adding custom jobs with institution and model validation
src/webapp/routers/data.py
Outdated
| id=job_run_id, | ||
| triggered_at=triggered_timestamp, | ||
| created_by=str_to_uuid(current_user.user_id), | ||
| batch_name="No batch name (manual custom school job)", |
Contributor
There was a problem hiding this comment.
The batch_name will show up on the frontend right? I think having no batch name like this will create a null point or will it just show "No batch name"? Do you know?
| batch_name="No batch name (manual custom school job)", | ||
| output_filename=f"{job_run_id}/inference_output.csv", | ||
| model_id=query_result[0][0].id, | ||
| output_valid=False, |
Contributor
There was a problem hiding this comment.
When is this set back to True?
Contributor
vishpillai123
left a comment
vishpillai123
left a comment
There was a problem hiding this comment.
The diff is a bit hard to read here because of the migration of all of the functions so just a heads up to put two PRs together next time!
vishpillai123
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
NEW ENDPOINT for adding custom school jobs to the JobTable in Cloud SQL. It leverages existing endpoint functions (read_model and read_inst) to validate that the institution and model exist before writing. This same function is used on Databricks, but it can also be called directly from the FastAPI interface.
Minor fixes: I also moved the front end table endpoints to a new file, to ensure it's clearer for debugging and testing