This repository was archived by the owner on Apr 17, 2018. It is now read-only.
issue solved when storage_name is different than class name#2
Open
sdesbure wants to merge 1 commit into
Open
Conversation
… to the model name and not the storage name.
For example, given this class:
Class BookResource
include DataMapper::Resource
storage_names[:default] = 'books'
property :id, Serial
property :created_at, DateTime
property :title, String
property :author, String
end
a POST or a PUT of this class would be:
<book-resource>
<id type='datamapper::types::serial'>1</id>
<created_at type='datetime'>2009-05-17T22:38:42-07:00</created_at>
<title>DataMapper</title>
<author>Dan Kubb</author>
</book-resource>
instead of the waited XML:
<book>
<id type='datamapper::types::serial'>1</id>
<created_at type='datetime'>2009-05-17T22:38:42-07:00</created_at>
<title>DataMapper</title>
<author>Dan Kubb</author>
</book>
This patch solve the problem and makes two tests to verify (one for create, one for update)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the patch, dm-rest is displaying the resource name accordingly to the model name and not the storage name.
For example, given this class:
Class BookResource
include DataMapper::Resource
storage_names[:default] = 'books'
a POST or a PUT of this class would be:
1
<created_at type='datetime'>2009-05-17T22:38:42-07:00</created_at>
<title>DataMapper</title>
Dan Kubb
instead of the waited XML:
1
<created_at type='datetime'>2009-05-17T22:38:42-07:00</created_at>
<title>DataMapper</title>
Dan Kubb
This patch solve the problem and makes two tests to verify (one for create, one for update)