refactor: replace *bool GrantTypeJWTBearerCopyAssertionAudience with plain bool GrantTypeJWTBearerOmitAssertionAudience#1
Merged
elatt merged 3 commits intoApr 10, 2026
Conversation
…ving pointer Agent-Logs-Url: https://github.com/datarobot-forks/hydra/sessions/b002d7b7-a0e5-4e55-b97d-4ab7d3450d04 Co-authored-by: elatt <2617872+elatt@users.noreply.github.com>
…plain bool GrantTypeJWTBearerOmitAssertionAudience Agent-Logs-Url: https://github.com/datarobot-forks/hydra/sessions/b002d7b7-a0e5-4e55-b97d-4ab7d3450d04 Co-authored-by: elatt <2617872+elatt@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
elatt
April 10, 2026 20:29
View session
Collaborator
|
@copilot why the changes to all the go dependency related files. I see no changes to anything dependency related in these changes. |
Agent-Logs-Url: https://github.com/datarobot-forks/hydra/sessions/2f217798-4d49-45a8-b852-44b3bf5e678c Co-authored-by: elatt <2617872+elatt@users.noreply.github.com>
Author
elatt
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback: the
*boolfield required non-standard pointer gymnastics just to express a default. Renaming toGrantTypeJWTBearerOmitAssertionAudience boollets the zero value (false) encode the backwards-compatible default (audience is copied), whiletrueopts in to omitting it.Changes
fosite/config_default.go— field changed fromGrantTypeJWTBearerCopyAssertionAudience *booltoGrantTypeJWTBearerOmitAssertionAudience bool; getter simplified (no nil check)fosite/config.go— interface renamedGrantTypeJWTBearerOmitAssertionAudienceProviderwith methodGetGrantTypeJWTBearerOmitAssertionAudiencefosite/fosite.go—Configuratorupdated to embed the renamed interfacefosite/handler/rfc7523/handler.go— condition flipped:if !c.Config.GetGrantTypeJWTBearerOmitAssertionAudience(ctx)driver/config/provider.go— key renamed tooauth2.grant.jwt.omit_assertion_audience, default is nowfalsevia plainBool()(noBoolFneeded).schema/config.schema.json/spec/config.json—copy_assertion_audience: true→omit_assertion_audience: falseGrantTypeJWTBearerOmitAssertionAudience = true(plain bool, no pointer) to assert omit behaviorRelated issue(s)
PR ory#4076
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.com) from the maintainers to push
the changes.
works.
Further Comments
The config key rename (
copy_assertion_audience→omit_assertion_audience) is a breaking change for anyone who set this value explicitly. Since the feature was only introduced in this PR branch and has not been released, no migration path is required.