feat(int): show settings and logs and add button to manually run task#21
Open
feat(int): show settings and logs and add button to manually run task#21
Conversation
RafDevX
requested changes
Apr 20, 2026
|
|
||
| impl PartialEq for BrowserDateTimeDto { | ||
| fn eq(&self, other: &Self) -> bool { | ||
| self.to_string() == other.to_string() |
Member
There was a problem hiding this comment.
Why not just #[derive(PartialEq)]? chrono::DateTime implements it, no?
| let run = services::integrations::list_runs(id, db.inner()) | ||
| .await? | ||
| .last() | ||
| .map(|run| run.clone()); |
Member
There was a problem hiding this comment.
Suggested change
| .map(|run| run.clone()); | |
| .cloned(); |
?
| Ok(integrations) | ||
| } | ||
|
|
||
| pub async fn list_settings<'x, X>( |
Member
There was a problem hiding this comment.
Don't include in this listing, or (best) don't show value for settings marked secret in the manifest. Probably return them here with value None, and then in the html template show (hidden) or some graphical thing. In general, secret values should never be displayed, only allowed to be overwritten, just like e.g. GitHub Actions Secrets
RafDevX
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.