Skip to content

Commit

Permalink
Update a comment
Browse files Browse the repository at this point in the history
  • Loading branch information
@pkolaczk
pkolaczk committed Sep 13, 2024
1 parent 6e0aa0d commit 5bed2c7
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/java/org/apache/cassandra/index/sai/utils/IndexFileUtils.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,8 @@ public class IndexFileUtils

/**
* Remembers checksums of files so we don't have to recompute them from the beginning of the file whenever appending
* to a file. Keeps checksums with respective file lengths so we can detect some file changes like truncation
* or external appends which could omit this code, so this is still safe.
* Index files are append-only (immutable), so length checking is enough.
* to a file. Keeps checksums with respective file lengths and footer checksums so we can detect file changes
* that don't go through this code, and we can evict stale entries.
*/
private static final Cache<String, Guard<FileChecksum>> checksumCache = Caffeine.newBuilder()
.maximumSize(4096)
Expand Down

1 comment on commit 5bed2c7

@cassci-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build rejected: 5 NEW test failure(s) in 10 builds., Build 11: ran 17605 tests with 10 failures and 128 skipped.
Butler analysis done on ds-cassandra-pr-gate/cndb-10873-segment-checksum vs last 16 runs of ds-cassandra-build-nightly/main.
org.apache.cassandra.index.sai.cql.TinySegmentQueryWriteLifecycleTest.testWriteLifecycle[aa_BaseDataModel{primaryKey=p}]: test is constantly failing. No failures on upstream;
branch story: [FFFFF] vs upstream: [++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++]; [NEW]
org.apache.cassandra.index.sai.disk.vector.VectorCompressionTest.testAda002: test looks flaky. No failures on upstream;
branch story: [+F++] vs upstream: [++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++]; [NEW]
org.apache.cassandra.index.sai.disk.vector.VectorCompressionTest.testOpenAiV3Large: test looks flaky. No failures on upstream;
branch story: [+F+F++F++F] vs upstream: [++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++]; [NEW]
org.apache.cassandra.index.sai.cql.VectorSiftSmallTest.testMultiSegmentBuild: test is constantly failing. No failures on upstream;
branch story: [FFFFFFFFFF] vs upstream: [++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++]; [NEW]
org.apache.cassandra.index.sai.cql.QueryWriteLifecycleTest.testWriteLifecycle[aa_CompoundKeyWithStaticsDataModel{primaryKey=p, c}]: test is constantly failing. No failures on upstream;
branch story: [FF] vs upstream: [++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++]; [NEW]
butler comparison

Please sign in to comment.