Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDB-11144: Support compilation and testing with j22 (by Ekaterina and co) #1323

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from

Commits on Oct 3, 2024

  1. Configuration menu
    Copy the full SHA
    b4bf82c View commit details
    Browse the repository at this point in the history
  2. Substitute ant script and scriptdef with custom ant tasks

    patch by Ekaterina Dimitrova; reviewed by Michaem Semb Wever for CASSANDRA-17224
    ekaterinadimitrova2 authored and jacek-lewandowski committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    18b4a99 View commit details
    Browse the repository at this point in the history
  3. Set correctly keepBriefBrief property

    patch by Ekaterina Dimitrova; reviewed by Andres de la Pena and Michael Semb Wever for CASSANDRA-18267
    ekaterinadimitrova2 authored and jacek-lewandowski committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2fc34a8 View commit details
    Browse the repository at this point in the history
  4. Assuming this is just test branch for newer JDK 17+, hacked G1 in bui…

    …ld.xml, same settings as Cassandra 5.0
    ekaterinadimitrova2 authored and jacek-lewandowski committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    32d2a3d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3e6a60a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5356eb4 View commit details
    Browse the repository at this point in the history
  7. Removes the use of CASSANDRA_USE_JDK11 and introduces the build.xml p…

    …roperties `java.default` and `java.supported`.
    
    ant generate-idea-files now support JDK 8, JDK 11 and JDK 22.
    To add support of another JDK the java-jvmargs property must be set for the JDK in question (see how it's done in build.xml for Java 11 and 22)
    
    Other minor, but notable changes are:
    - test jvmargs are now added to idea run configurations
    - .idea dir and project iml file are first removed and then recreated during `ant generate-idea-files`
    
    Based on what was done in CASSANDRA-18467, CASSANDRA-18179, CASSANDRA-18258 for 17 plus additional stuff for 21
    
    Co-authored-by: Ekaterina Dimitrova<[email protected]>
    Co-authored-by: Mick Semb Wever <[email protected]>
    Co-authored-by: Jakub Zytka <[email protected]>
    2 people authored and jacek-lewandowski committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d32d609 View commit details
    Browse the repository at this point in the history
  8. Revisited add-exports and add-opens. Need to change the order in the …

    …jvm options, to match the order in the other files/places
    
    There is a chance this fixes some tests (or breakes more?)
    ekaterinadimitrova2 authored and jacek-lewandowski committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    6202eb1 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8476cce View commit details
    Browse the repository at this point in the history
  10. Fixes

    ekaterinadimitrova2 authored and jacek-lewandowski committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    861d503 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    8126baa View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    fd4c981 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    cbbc9f6 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    93038f2 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    7203da9 View commit details
    Browse the repository at this point in the history
  16. Fix tools tests

    ekaterinadimitrova2 authored and jacek-lewandowski committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    9a07b12 View commit details
    Browse the repository at this point in the history
  17. Bump netty - technically we need a full port of CASSANDRA-17992 and C…

    …ASSANDRA-18723 but I figured I want to stay more conservative for this branch. This bump requires more testing than only the unit testing. Also, it looks like that some netty defaults have changed before and we agreed with that. (In Cassandra we added io.netty.allocator.useCacheForAllThreads=true, io.netty.allocator.maxOrder=11, this was not done here)
    ekaterinadimitrova2 authored and jacek-lewandowski committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    71a01d2 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    d5a9e4f View commit details
    Browse the repository at this point in the history
  19. Remove mocking in InternalNodeProbe spying on StorageServiceMBean

    patch by Stefan Miklosovic; reviewed by Andrés de la Peña for CASSANDRA-18152
    
    Fix for org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest
    smiklosovic authored and jacek-lewandowski committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    cb4ed6f View commit details
    Browse the repository at this point in the history
  20. CASSANDRA-18180 Fix bulkLoaderSuccessfullyStreamsOverSsl fails with C…

    …lassCastException on JDK17
    
    Fix ClassCastException  from jdk GaloisCounterMode when using JDK17 provider
    
    Add javac exports to build.xml for java.base/jdk.internal.ref and java.base/sun.nio.ch
    
    Replace checktestnameshelper ant task in build.xml with _check-test-names java target to be able to pass jvm args to TestNameCheckTask
    
    patch by Dan Janieks; revewed by Ekaterina Dimitrova and Andres de la Pena for CASSANDRA-18180
    djatnieks authored and jacek-lewandowski committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    11e73c7 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    e042db8 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    944f2e6 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    61b374a View commit details
    Browse the repository at this point in the history
  24. Fix tools/bin/cassandra.in.sh; fix some JDK internals openings for au…

    …dit logger and vectorizedMismatch
    ekaterinadimitrova2 authored and jacek-lewandowski committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    c642a02 View commit details
    Browse the repository at this point in the history
  25. Port CASSANDRA-18190, this fixes the tests for now, but maybe we stil…

    …l want to check newer version for JDK22 specifically
    ekaterinadimitrova2 authored and jacek-lewandowski committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    77c8f5d View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    44867a6 View commit details
    Browse the repository at this point in the history
  27. Upgrade Jamm version to 0.4.0

    This upgrade also fixes issues with PhantomReferences and the test problems from CASSANDRA-17884 anad CASSANDRA-16304
    
    patch by Benjamin Lerer; reviewed by Ekaterina Dimitrova for CASSANDRA-18239
    blerer authored and jacek-lewandowski committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    dde5e38 View commit details
    Browse the repository at this point in the history
  28. cherry-pick conflict solved, the jamm upgrade may need some thorough …

    …revision and work if we decide to do it here; the cherry-pick was quick for testing without spending too much time on details
    ekaterinadimitrova2 authored and jacek-lewandowski committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b0a5dca View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    3837c04 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    57401d9 View commit details
    Browse the repository at this point in the history
  31. Revert "cherry-pick conflict solved, the jamm upgrade may need some t…

    …horough revision and work if we decide to do it here; the cherry-pick was quick for testing without spending too much time on details"
    
    This reverts commit b160b80.
    ekaterinadimitrova2 authored and jacek-lewandowski committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    dfef1ed View commit details
    Browse the repository at this point in the history
  32. Revert "Upgrade Jamm version to 0.4.0"

    This reverts commit 6e1eb3b.
    ekaterinadimitrova2 authored and jacek-lewandowski committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    3a52327 View commit details
    Browse the repository at this point in the history
  33. Ran into an odd situation where, on jdk21, antlr crashed first time t…

    …hrough then worked 2nd. Forking it fixes this.
    ekaterinadimitrova2 authored and jacek-lewandowski committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    bda466e View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    24b842f View commit details
    Browse the repository at this point in the history
  35. 1 Configuration menu
    Copy the full SHA
    5696964 View commit details
    Browse the repository at this point in the history
  36. 1 Configuration menu
    Copy the full SHA
    76c8dd6 View commit details
    Browse the repository at this point in the history
  37. Update SyncUtil for JDK11 and JDK17

    Remove --add-opens java.base/java.nio=ALL-UNNAMED which is not needed anymore
    
    patch by Ekaterina Dimitrova; reviewed by Jacek Lewandowki for CASSANDRA-17909
    ekaterinadimitrova2 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a3fd4ff View commit details
    Browse the repository at this point in the history