Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDB-12437: BigTableScanner should throw an IllegalStateException if the next row iterator is requested without consuming the previous #1511

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

jkni
Copy link

@jkni jkni commented Jan 16, 2025

What is the issue

SSTableScannerTest tests for scanners throwing an IllegalStateException in this scenario fails for bigtable.

What does this PR fix and why was it fixed

This PR adds the same check for BigTableScanner as TrieIndexScanner already had. Improved test coverage exposed this as a genuine defect; BigTableScanner should contain this check, and its absence was an error.

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

@jkni jkni requested review from a team and blambov January 16, 2025 22:35
@jkni
Copy link
Author

jkni commented Jan 16, 2025

This patch was recommended by Branimir. I agree that its absence was an error.

…the next row iterator is requested without consuming the previous
@cassci-bot
Copy link

✔️ Build ds-cassandra-pr-gate/PR-1511 approved by Butler


Approved by Butler
See build details here

@jkni jkni merged commit 845d600 into main Jan 21, 2025
460 of 474 checks passed
@jkni jkni deleted the CNDB-12437 branch January 21, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants