CNDB-17012: Improve TrieMemoryIndex row count estimation#2262
Merged
Conversation
Checklist before you submit for review
|
58dc2a8 to
3ea235f
Compare
adelapena
reviewed
Mar 9, 2026
a238f83 to
d1532b7
Compare
|
d1532b7 to
5584ab0
Compare
adelapena
approved these changes
Apr 24, 2026
adelapena
left a comment
There was a problem hiding this comment.
LGTM. I would only add a comment on the new test about the limitations of the algorithm, basically what is said by this comment: #2262 (comment)
Fixes a bug in TermsDistribution#toBigDecimal which didn't preserve order for some types and broke the assertion in TrieMemoryIndex#estimateNumRowsMatchingRange. Additionally, replaces the row count estimation algorithm with a better one: - simpler - more efficient (no need to search and iterate the trie) - more accurate (especially for wider ranges)
5584ab0 to
802773b
Compare
|
❌ Build ds-cassandra-pr-gate/PR-2262 rejected by Butler4 regressions found Found 4 new test failures
Found 7 known test failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes a bug in TermsDistribution#toBigDecimal which didn't preserve
order for some types and broke the assertion
in TrieMemoryIndex#estimateNumRowsMatchingRange.
Additionally, replaces the row count estimation algorithm with a better
one: