Skip to content

CNDB-17110: Fix possible deadlock if flush fails #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pkolaczk merged 1 commit into from
Mar 24, 2026
Merged

CNDB-17110: Fix possible deadlock if flush fails #2275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions src/java/org/apache/cassandra/db/ColumnFamilyStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1356,18 +1356,25 @@ public void run()
}
catch (Throwable t)
{
JVMStabilityInspector.inspectThrowable(t);
postFlush.flushFailure = t;
Comment thread
pkolaczk marked this conversation as resolved.
JVMStabilityInspector.inspectThrowable(t);
}
finally
{
if (logger.isTraceEnabled())
logger.trace("Flush task {}@{} signaling post flush task", hashCode(), name);

if (logger.isTraceEnabled())
logger.trace("Flush task {}@{} signaling post flush task", hashCode(), name);

// signal the post-flush we've done our work
postFlush.latch.countDown();
// signal the post-flush we've done our work
postFlush.latch.countDown();

if (logger.isTraceEnabled())
logger.trace("Flush task task {}@{} finished", hashCode(), name);
if (logger.isTraceEnabled())
{
if (postFlush.flushFailure != null)
logger.trace("Flush task task {}@{} failed", hashCode(), name);
else
logger.trace("Flush task task {}@{} finished successfully", hashCode(), name);
}
}
}

public Collection<SSTableReader> flushMemtable(ColumnFamilyStore cfs, Memtable memtable, boolean flushNonCf2i)
Expand Down