CNDB-17275 put using histograms estimations in query planner under flag#2290
Merged
CNDB-17275 put using histograms estimations in query planner under flag#2290
Conversation
Checklist before you submit for review
|
e80af09 to
4ef160e
Compare
adelapena
approved these changes
Apr 1, 2026
PR #1253 switched query planner to use histograms for rows estimations. This can change query plans in existing databases leading to different performance. To avoid such change during upgrade, a flag, which controls using or not histograms, i.e., old vs new way of estimating rows, is introduced and set to FALSE by default.
4ef160e to
434d970
Compare
|
|
Sonar seems to have some problem with coverage analysis. I tested coverage manually and QueryController lines are covered by tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What is the issue
Fixes https://github.com/riptano/cndb/issues/17275
PR #1253 switched query planner to use histograms for rows estimations. This can change query plans in existing databases leading to different performance.
What does this PR fix and why was it fixed
To avoid such change during upgrade a flag, which controls using or not histograms, i.e., old vs new way of estimating rows, is introduced and set to FALSE by default.
The flag is set to TRUE for SAI tests.