Port CNDB-17080 to main: Add flag to enable/disable SAI histogram metrics #2303
Port CNDB-17080 to main: Add flag to enable/disable SAI histogram metrics #2303niksajakovljevic merged 1 commit intomainfrom
Conversation
Checklist before you submit for review
|
|
I see 0 test coverage but the original PR we port clearly shows 100% test coverage - #2267 (comment) There is ongoing issue discussed here, so we can ignore that for now: https://datastax.slack.com/archives/C0AJK5ME4PN/p1775130881404449 I will review now the code |
ekaterinadimitrova2
left a comment
There was a problem hiding this comment.
All tests but the VectorLocalTests are known vector tests timing out. There is a WIP from Michael that we will need to pick up once we have cycles for those.
The 0% coverage is wrong and we have 100% coverage as in the original commit and the tests pass.
Please update the commit message before merge, I believe it should point to CNDB-17155
I also opened a ticket for the VectorLocalTests
Thanks for porting this!
…leIndexWriteLatency, termsTraversalTotalTime, intersectionLatency, queryLatency (#2267) ... We want to be able to disable SAI histogram metrics ... Add flag to enable/disable SAI histogram metrics - `memtableIndexWriteLatency, termsTraversalTotalTime, intersectionLatency`, `queryLatency` `-Dcassandra.sai.metrics.histograms.enabled` The metrics are kept enabled by default as they were before. --------- Port to main Co-authored-by: Andrés de la Peña <adelapena@users.noreply.github.com>
72a4f24 to
800c54d
Compare
|
❌ Build ds-cassandra-pr-gate/PR-2303 rejected by Butler4 regressions found Found 4 new test failures
Found 9 known test failures |



CNDB-17080: Add flag to enable/disable SAI histogram metrics - memtableIndexWriteLatency, termsTraversalTotalTime, intersectionLatency, queryLatency (#2267)
What is the issue
...
We want to be able to disable SAI histogram metrics
What does this PR fix and why was it fixed
...
Add flag to enable/disable SAI histogram metrics -
memtableIndexWriteLatency, termsTraversalTotalTime, intersectionLatency,queryLatency-Dcassandra.sai.metrics.histograms.enabledThe metrics are kept enabled by default as they were before.
Co-authored-by: Andrés de la Peña adelapena@users.noreply.github.com
Port of #2267