Skip to content

Port CNDB-17080 to main: Add flag to enable/disable SAI histogram metrics #2303

Merged
niksajakovljevic merged 1 commit intomainfrom
cndb-17155-main
Apr 6, 2026
Merged

Port CNDB-17080 to main: Add flag to enable/disable SAI histogram metrics #2303
niksajakovljevic merged 1 commit intomainfrom
cndb-17155-main

Conversation

@niksajakovljevic
Copy link
Copy Markdown
Collaborator

CNDB-17080: Add flag to enable/disable SAI histogram metrics - memtableIndexWriteLatency, termsTraversalTotalTime, intersectionLatency, queryLatency (#2267)

What is the issue

...
We want to be able to disable SAI histogram metrics

What does this PR fix and why was it fixed

...
Add flag to enable/disable SAI histogram metrics -
memtableIndexWriteLatency, termsTraversalTotalTime, intersectionLatency, queryLatency

-Dcassandra.sai.metrics.histograms.enabled
The metrics are kept enabled by default as they were before.


Co-authored-by: Andrés de la Peña adelapena@users.noreply.github.com

Port of #2267

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@ekaterinadimitrova2
Copy link
Copy Markdown

I see 0 test coverage but the original PR we port clearly shows 100% test coverage - #2267 (comment)

There is ongoing issue discussed here, so we can ignore that for now: https://datastax.slack.com/archives/C0AJK5ME4PN/p1775130881404449

I will review now the code

Copy link
Copy Markdown

@ekaterinadimitrova2 ekaterinadimitrova2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests but the VectorLocalTests are known vector tests timing out. There is a WIP from Michael that we will need to pick up once we have cycles for those.

The 0% coverage is wrong and we have 100% coverage as in the original commit and the tests pass.
Please update the commit message before merge, I believe it should point to CNDB-17155

I also opened a ticket for the VectorLocalTests

Thanks for porting this!

…leIndexWriteLatency, termsTraversalTotalTime, intersectionLatency, queryLatency (#2267)

...
We want to be able to disable SAI histogram metrics
...
Add flag to enable/disable SAI histogram metrics -
`memtableIndexWriteLatency, termsTraversalTotalTime,
intersectionLatency`, `queryLatency`

`-Dcassandra.sai.metrics.histograms.enabled`
The metrics are kept enabled by default as they were before.

---------

Port to main

Co-authored-by: Andrés de la Peña <adelapena@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 6, 2026

@cassci-bot
Copy link
Copy Markdown

@niksajakovljevic niksajakovljevic merged commit db60760 into main Apr 6, 2026
2 of 4 checks passed
@niksajakovljevic niksajakovljevic deleted the cndb-17155-main branch April 6, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants