Skip to content

CNDB-17453: fix flaky cleanup timing assertion in FlushFailingOnNotificationSubscriberTest#2316

Merged
driftx merged 1 commit intomain-5.0from
CNDB-17543
Apr 21, 2026
Merged

CNDB-17453: fix flaky cleanup timing assertion in FlushFailingOnNotificationSubscriberTest#2316
driftx merged 1 commit intomain-5.0from
CNDB-17543

Conversation

@driftx
Copy link
Copy Markdown

@driftx driftx commented Apr 10, 2026

What does this PR fix and why was it fixed

Reset lastTimePoolNeededCleaning after successful flushes so the cleanup gap measurement doesn't span flush boundaries.

@github-actions
Copy link
Copy Markdown

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

…icationSubscriberTest

Reset lastTimePoolNeededCleaning after successful flushes so the cleanup
gap measurement doesn't span flush boundaries.
@sonarqubecloud
Copy link
Copy Markdown

@cassci-bot
Copy link
Copy Markdown

@djatnieks djatnieks changed the title CNDB-17543: fix flaky cleanup timing assertion in FlushFailingOnNotificationSubscriberTest CNDB-17453: fix flaky cleanup timing assertion in FlushFailingOnNotificationSubscriberTest Apr 20, 2026
@driftx driftx merged commit ca6ad57 into main-5.0 Apr 21, 2026
4 of 6 checks passed
@driftx driftx deleted the CNDB-17543 branch April 21, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants