Skip to content

CNDB-16203: Make the counters in QueryContext plain longs (#2153)#2326

Merged
driftx merged 1 commit intomain-5.0from
CNDB-16699
Apr 20, 2026
Merged

CNDB-16203: Make the counters in QueryContext plain longs (#2153)#2326
driftx merged 1 commit intomain-5.0from
CNDB-16699

Conversation

@driftx
Copy link
Copy Markdown

@driftx driftx commented Apr 16, 2026

We don't need all the counters in QueryContext to be LongAdder, since they are only accessed by the query's thread.

They used to be plain longs until VECTOR-SEARCH-29 parallelized vector searches, making them accessed by multiple threads. However, that parallelization was removed by the BM25 patch.

The system properties USE_PARALLEL_INDEX_READ and PARALLEL_INDEX_READ_NUM_THREADS are removed, since they were no-op since the introduction of BM25. Since we don't reject unknown system properties, they will remain no-op.

We don't need all the counters in QueryContext to be LongAdder, since they are
only accessed by the query's thread.

They used to be plain longs until VECTOR-SEARCH-29 parallelized vector searches,
making them accessed by multiple threads. However, that parallelization was
removed by the BM25 patch.

The system properties USE_PARALLEL_INDEX_READ and PARALLEL_INDEX_READ_NUM_THREADS
are removed, since they were no-op since the introduction of BM25. Since we don't
reject unknown system properties, they will remain no-op.
@github-actions
Copy link
Copy Markdown

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@driftx
Copy link
Copy Markdown
Author

driftx commented Apr 16, 2026

Nothing substantial, minor CassandraRelevantProperties changes.

@sonarqubecloud
Copy link
Copy Markdown

@cassci-bot
Copy link
Copy Markdown

❌ Build ds-cassandra-pr-gate/PR-2326 rejected by Butler


3 regressions found
See build details here


Found 3 new test failures

Test Explanation Runs Upstream
o.a.c.concurrent.StageTimeMeasurementTest.executionAndQueueTimeAreCountedOnSubmitWithResult (compression) REGRESSION 🔴 0 / 30
o.a.c.index.sai.cql.VectorCompaction100dTest.testOneToManyCompaction[dc true] () NEW 🔴 0 / 30
o.a.c.index.sai.cql.VectorSiftSmallTest.testSiftSmall[dc false] () NEW 🔴 0 / 30

Found 1 known test failures

Copy link
Copy Markdown
Member

@djatnieks djatnieks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: the StageTimeMeasurementTest failures in CI also fail locally for me on main-5.0

@driftx driftx merged commit 4d4b2c1 into main-5.0 Apr 20, 2026
5 of 7 checks passed
@driftx driftx deleted the CNDB-16699 branch April 20, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants