CNDB-16203: Make the counters in QueryContext plain longs (#2153)#2326
Merged
CNDB-16203: Make the counters in QueryContext plain longs (#2153)#2326
Conversation
We don't need all the counters in QueryContext to be LongAdder, since they are only accessed by the query's thread. They used to be plain longs until VECTOR-SEARCH-29 parallelized vector searches, making them accessed by multiple threads. However, that parallelization was removed by the BM25 patch. The system properties USE_PARALLEL_INDEX_READ and PARALLEL_INDEX_READ_NUM_THREADS are removed, since they were no-op since the introduction of BM25. Since we don't reject unknown system properties, they will remain no-op.
Checklist before you submit for review
|
Author
|
Nothing substantial, minor CassandraRelevantProperties changes. |
|
❌ Build ds-cassandra-pr-gate/PR-2326 rejected by Butler3 regressions found Found 3 new test failures
Found 1 known test failures |
djatnieks
approved these changes
Apr 17, 2026
Member
djatnieks
left a comment
There was a problem hiding this comment.
note: the StageTimeMeasurementTest failures in CI also fail locally for me on main-5.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



We don't need all the counters in QueryContext to be LongAdder, since they are only accessed by the query's thread.
They used to be plain longs until VECTOR-SEARCH-29 parallelized vector searches, making them accessed by multiple threads. However, that parallelization was removed by the BM25 patch.
The system properties USE_PARALLEL_INDEX_READ and PARALLEL_INDEX_READ_NUM_THREADS are removed, since they were no-op since the introduction of BM25. Since we don't reject unknown system properties, they will remain no-op.