Conversation
Checklist before you submit for review
|
Collaborator
|
@blambov This code looks very familiar to the DSE side one. The only CI failure Butler reports it's a timeout. I only have one q: Does the last commit lack a test maybe? |
Author
|
Test added. |
Encrypted primary index files are written in a way that hides encryption metadata in holes in the file. Non-trie data like primary keys may span over these holes, which is handled correctly when we read these keys. However, when we skip a key instead of reading it, we may end up in the wrong position if the key is longer than the metadata.
Log error and let operations continue when an early open attempt fails. Change online scrub to not use early open as it is unsafe.
Remove unnecessary double minimization
|
❌ Build ds-cassandra-pr-gate/PR-2544 rejected by Butler3 regressions found Found 3 new test failures
Found 7 known test failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What is the issue
DSP-25176
Encrypted primary index files are written in a way that hides encryption metadata in holes in the file. Non-trie data like primary keys may span over these holes, which is handled correctly when we read these keys.
However, when we skip a key instead of reading it, we may end up in the wrong position if the key is longer than the metadata.
What does this PR fix and why was it fixed
Implements skip position correction for encrypted primary index files.
Also corrects problems listing partitions when the boundaries of an sstable have been reduced due to zero-copy streaming metadata.
Adds tests for both problems.
Disables early opening for online scrub, which is unsafe because data may transiently disappear.
Makes sure that failed attempts to open a compaction result early are logged but do not stop the operation, by rolling back the prepared transaction checkpoint on error.
Fixes incorrect row index length in openFinalEarly.
Fixes incorrect DecoratedKey minimization.
CC5 PR: #2547
DSE PR: https://github.com/riptano/bdp/pull/21750