CNDB-18565: Separately enable generic histogram for SAI queries latency - #2577
Open
adelapena wants to merge 1 commit into
Open
CNDB-18565: Separately enable generic histogram for SAI queries latency#2577adelapena wants to merge 1 commit into
adelapena wants to merge 1 commit into
Conversation
# Conflicts: # src/java/org/apache/cassandra/config/CassandraRelevantProperties.java
Checklist before you submit for review
|
|
❌ Build ds-cassandra-pr-gate/PR-2577 rejected by Butler3 regressions found Found 3 new test failures
Found 2 known test failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What is the issue
Currently we have two histograms for query latency in CNDB, one for range queries and other for single-partition queries.
We usually assume that range queries are SAI queries because before https://github.com/riptano/cndb/issues/16859 all index queries are translated into range queries. However, after that patch SAI queries can be single-partition. Also, regardless of https://github.com/riptano/cndb/issues/16859 we can have queries with
ALLOW FILTERINGthat are difficult to distinguish from SAI queries.Histograms in CNDB are expensive, but we should probably consider adding yet another CNDB histogram for the latency of SAI queries.
What does this PR fix and why was it fixed
Allow to enable the histogram for the latency of SAI queries of any kind, regardless of the
cassandra.sai.metrics.histograms.enabledsystem property, with a newcassandra.sai.metrics.histograms.all_queries.enabled. The histogram will be enabled if any of those two properties is true.All the other similar histograms still depend on the
cassandra.sai.metrics.histograms.enabledsystem property alone.