Skip to content

simplified astra adapter implementation #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

simplified astra adapter implementation #174

merged 1 commit into from
Apr 4, 2025

Conversation

epinzur
Copy link
Collaborator

@epinzur epinzur commented Apr 3, 2025

No description provided.

@epinzur epinzur requested a review from bjchambers April 3, 2025 17:56
@coveralls
Copy link

coveralls commented Apr 3, 2025

Pull Request Test Coverage Report for Build 14249588432

Details

  • 103 of 103 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 93.649%

Files with Coverage Reduction New Missed Lines %
packages/langchain-graph-retriever/src/langchain_graph_retriever/adapters/astra.py 1 95.82%
Totals Coverage Status
Change from base Build 14243578006: 0.06%
Covered Lines: 1589
Relevant Lines: 1670

💛 - Coveralls

Copy link

github-actions bot commented Apr 3, 2025

Test Results

    8 files  ±0      8 suites  ±0   3m 12s ⏱️ +24s
  528 tests  - 2    504 ✅  - 2   24 💤 ±0  0 ❌ ±0 
2 112 runs   - 8  1 124 ✅  - 8  988 💤 ±0  0 ❌ ±0 

Results for commit 651cbfc. ± Comparison against base commit 9561d9f.

This pull request removes 2 tests.
packages.langchain-graph-retriever.tests.adapters.test_astra ‑ test_create_ids_query_no_user
packages.langchain-graph-retriever.tests.adapters.test_astra ‑ test_create_ids_query_user

@epinzur epinzur merged commit bb19f38 into main Apr 4, 2025
9 checks passed
@epinzur epinzur deleted the cleanup_astra branch April 4, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants