Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up zoonavigator version #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump up zoonavigator version #102

wants to merge 1 commit into from

Conversation

yabinmeng
Copy link

The current zoonavigator docker image version in the helm chart is 0.6 which is deprecated.
Bump up the version to the latest version.

tag: 0.6.0
web: elkozmon/zoonavigator
api: elkozmon/zoonavigator
tag: latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since users can override this image tag manually in their values files, I think we should specify an actual version instead of latest here.

Comment on lines +1504 to +1505
web: elkozmon/zoonavigator
api: elkozmon/zoonavigator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can collapse the two images. I'll need to take a closer look at the release notes to understand the difference between these two images, since they appear to be collapsed now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense

@michaeljmarshall
Copy link
Member

This PR will fix #88.

@robparrott
Copy link

robparrott commented Feb 7, 2022

Just this change did not work for me, but a modified deployment for zoonavigator that had the following spec section worked:

    spec:
      containers:
        - name: pulsar-zoonavigator
          image: elkozmon/zoonavigator:1.1.1
          ports:
            - name: http
              containerPort: 8001
              protocol: TCP
          env:
            - name: HTTP_PORT
              value: '8001'
            - name: CONNECTION_PULSARZK_CONN
              value: pulsar-zookeeper-0.pulsar-zookeeper:2181
            - name: CONNECTION_PULSARZK_NAME
              value: Pulsar ZooKeeper
            - name: AUTO_CONNECT_CONNECTION_ID
              value: PULSARZK
          resources:
            requests:
              cpu: 100m
              memory: 128Mi
          terminationMessagePath: /dev/termination-log
          terminationMessagePolicy: File
          imagePullPolicy: IfNotPresent

Note the removal of the secondary container, and the modified ENV variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants