-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpsCenter 6.8.42 Release #186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a suggestion but looks good to me otherwise. 👍
OpsCenter_6.8_Release_Notes.md
Outdated
|
||
## Backup Service | ||
* Added support for picking individual tables when creating a backup. (OPSC-17084) | ||
* Updated aws sdk version. Aws cli will now be used for bucket validation if `use_s3_cli` is true. This resolves issues when using some generic S3 providers such as Cloudian. (OPSC-17639) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A friendly suggestion -- minor nit with capitalisation of proper nouns for consistency. For example, "Azure SDK" was previously referenced.
* Updated aws sdk version. Aws cli will now be used for bucket validation if `use_s3_cli` is true. This resolves issues when using some generic S3 providers such as Cloudian. (OPSC-17639) | |
* Updated AWS SDK version. AWS CLI will now be used for bucket validation if `use_s3_cli` is true. This resolves issues when using some generic S3 providers such as Cloudian. (OPSC-17639) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErickRamirezDS's comments are good. I've added some additional suggestions below from the docs perspective, and included the AWS SDK version number from the pull request. Feel free to make changes as needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @orion104 - I've added some suggestions from the docs side. Take a look and let me know what you think. Otherwise, LGTM!
Thanks, Richard
Co-authored-by: Richard Hendricks <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Release Notes Automation
If you name your pull-request as "Product x.y.z Release ...", after merging the
PR, a GitHub Action will automatically create a product version tag "product-x.y.z".
Supported product names are:
Version supports 3 sets or 4 sets of digits.