Reduce allocations in PulsarEntryFormatter batch encoding#126
Open
Denovo1998 wants to merge 6 commits intodatastax:4.0_dsfrom
Open
Reduce allocations in PulsarEntryFormatter batch encoding#126Denovo1998 wants to merge 6 commits intodatastax:4.0_dsfrom
Denovo1998 wants to merge 6 commits intodatastax:4.0_dsfrom
Conversation
This reverts commit 7837294.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PulsarEntryFormattercurrently builds an intermediate list of converted messages before serializing the final batch payload, which adds extra allocations and increases peak memory usage. In addition, the batch buffer starts with a small fixed size and is only released on the normal return path, which can lead to unnecessary buffer growth and potential ByteBuf leaks if an exception occurs. Streamlining the encode path reduces overhead and makes the transactional/control metadata handling easier to follow.Modifications
AppendInfo.validBytes()(bounded by a maximum) to reduce reallocations and copies.isTransactional/isControlBatchper record batch to reduce repeated checks and improve readability.log.isTraceEnabled()to avoid extra overhead in normal operation.try/finallyto prevent leaks on error paths.