Complete ResponseCallbackWrapper on encoding failure#127
Open
Denovo1998 wants to merge 1 commit intodatastax:4.0_dsfrom
Open
Complete ResponseCallbackWrapper on encoding failure#127Denovo1998 wants to merge 1 commit intodatastax:4.0_dsfrom
Denovo1998 wants to merge 1 commit intodatastax:4.0_dsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/Denovo1998/starlight-for-kafka/actions/runs/20877709389?pr=1
Motivation
ResponseCallbackWrapper is used to run cleanup logic after a response is written to the network channel. When KafkaCommandDecoder fails to convert a response to ByteBuf, we currently send an error response but never invoke the wrapper’s completion callback, which can leave cleanup logic unexecuted and potentially leak in-flight request state. This PR ensures the callback is completed on the failure path as well, and aligns the related fetch test to always complete the wrapper after inspection.
Modifications