Refactor ReadFiles class for file handling#156
Open
osquerkkzlk wants to merge 2 commits intodatawhalechina:mainfrom
Open
Refactor ReadFiles class for file handling#156osquerkkzlk wants to merge 2 commits intodatawhalechina:mainfrom
osquerkkzlk wants to merge 2 commits intodatawhalechina:mainfrom
Conversation
Contributor
|
感谢贡献!read_pdf 的重构很简洁,但 get_files 里有一个 bug 需要修复: init 中定义的属性名是 self._path,但新代码改成了 self.path,会导致运行时抛出 AttributeError。 需要改回for file_path, dir_names, file_names in os.walk(self._path): 另外新代码有几处不符合 PEP 8 的写法,建议顺手修一下: 当前file_list=[] 建议file_list = [] 修复后可以合并,read_pdf 那部分的改进是好的 � |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
简化代码结构