Skip to content

Refactor ReadFiles class for file handling#156

Open
osquerkkzlk wants to merge 2 commits intodatawhalechina:mainfrom
osquerkkzlk:main
Open

Refactor ReadFiles class for file handling#156
osquerkkzlk wants to merge 2 commits intodatawhalechina:mainfrom
osquerkkzlk:main

Conversation

@osquerkkzlk
Copy link

简化代码结构

@KMnO4-zx
Copy link
Contributor

感谢贡献!read_pdf 的重构很简洁,但 get_files 里有一个 bug 需要修复:

init 中定义的属性名是 self._path,但新代码改成了 self.path,会导致运行时抛出 AttributeError。

需要改回

for file_path, dir_names, file_names in os.walk(self._path):

另外新代码有几处不符合 PEP 8 的写法,建议顺手修一下:

当前

file_list=[]

建议

file_list = []

修复后可以合并,read_pdf 那部分的改进是好的 �

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants