Skip to content

Dev #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FutureUnreal merged 3 commits into from
Feb 7, 2026
+662 −38
Merged

Dev #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e4efe6
合并 (#8)
FutureUnreal Feb 7, 2026
f9e42d0
chore: add comprehensive contributing guide (#10)
FutureUnreal Feb 7, 2026
b01183a
ci: restore pr-check.yml workflow for dev branch
FutureUnreal Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 3 additions & 38 deletions .github/workflows/pr-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,76 +15,41 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5

- name: Detect backend
id: detect
run: |
if [ -f backend/pyproject.toml ]; then
echo "exists=true" >> "$GITHUB_OUTPUT"
else
echo "exists=false" >> "$GITHUB_OUTPUT"
fi

- name: Skip backend checks (no backend/)
if: steps.detect.outputs.exists != 'true'
run: echo "No backend/ found; skipping backend checks."

- name: Setup Python
if: steps.detect.outputs.exists == 'true'
uses: actions/setup-python@v5
with:
python-version: "3.11"
cache: "pip"
cache-dependency-path: backend/pyproject.toml
- name: Install backend (editable)
if: steps.detect.outputs.exists == 'true'
run: |
python -m pip install --upgrade pip
pip install -e backend
Comment on lines 24 to 27
Copy link
Contributor

@greptile-apps greptile-apps bot Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow now assumes backend/ always exists. If the directory is removed or backend/pyproject.toml is missing, the job will fail. Consider adding a path filter or keeping the detection logic:

Suggested change
- name: Install backend (editable)
if: steps.detect.outputs.exists == 'true'
run: |
python -m pip install --upgrade pip
pip install -e backend
- name: Detect backend
id: detect
run: |
if [ -f backend/pyproject.toml ]; then
echo "exists=true" >> "$GITHUB_OUTPUT"
else
echo "exists=false" >> "$GITHUB_OUTPUT"
fi
- name: Install backend (editable)
if: steps.detect.outputs.exists == 'true'
run: |

Or use path filters in the workflow trigger to only run when backend files change.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

- name: Backend syntax check (compileall)
if: steps.detect.outputs.exists == 'true'
run: python -m compileall -q backend/app
- name: Backend import smoke test
if: steps.detect.outputs.exists == 'true'
run: python -c "from app.main import app; print('backend app import: ok')"

frontend:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
defaults:
run:
working-directory: frontend
steps:
- uses: actions/checkout@v5

- name: Detect frontend
id: detect
run: |
if [ -f frontend/pnpm-lock.yaml ] || [ -f frontend/package.json ]; then
echo "exists=true" >> "$GITHUB_OUTPUT"
else
echo "exists=false" >> "$GITHUB_OUTPUT"
fi

- name: Skip frontend checks (no frontend/)
if: steps.detect.outputs.exists != 'true'
run: echo "No frontend/ found; skipping frontend checks."

- name: Setup Node.js
if: steps.detect.outputs.exists == 'true'
uses: actions/setup-node@v4
with:
node-version: "20"
cache: "pnpm"
cache-dependency-path: frontend/pnpm-lock.yaml
- name: Setup pnpm
if: steps.detect.outputs.exists == 'true'
uses: pnpm/action-setup@v4
with:
version: "9.12.2"
run_install: false
- name: Install dependencies
if: steps.detect.outputs.exists == 'true'
working-directory: frontend
run: pnpm install --frozen-lockfile
Comment on lines 52 to 53
Copy link
Contributor

@greptile-apps greptile-apps bot Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, the workflow now assumes frontend/ always exists. If frontend/pnpm-lock.yaml is missing, the job will fail. Consider keeping detection logic or using path filters.

- name: Build web app
if: steps.detect.outputs.exists == 'true'
working-directory: frontend
run: pnpm --filter @whalewhisper/web build
Loading
Loading