Skip to content

feat: modification-header-check#8

Merged
hash-data merged 11 commits into
stagingfrom
ci/license-header-check
Feb 27, 2026
Merged

feat: modification-header-check#8
hash-data merged 11 commits into
stagingfrom
ci/license-header-check

Conversation

@arsalan-datazip

Copy link
Copy Markdown
Collaborator

Why are the changes needed?

This PR adds a CI workflow that validates license.

Brief change log

GitHub Actions workflow that runs on push and pull requests, checks all modified files for required license headers

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

@hash-data hash-data deleted the branch staging February 14, 2026 15:26
@hash-data hash-data closed this Feb 14, 2026
@hash-data hash-data reopened this Feb 14, 2026

@badalprasadsingh badalprasadsingh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check why the License check is failing on this PR.

Added first level review comments. Will review and test again in the next iteration.

Comment thread .github/workflows/license-check.yml Outdated
Comment thread .github/workflows/license-check.yml Outdated
Comment thread .github/workflows/license-check.yml Outdated
Comment thread .github/workflows/license-check.yml Outdated
Comment thread .github/workflows/license-check.yml Outdated
Comment thread .github/workflows/license-check.yml Outdated

@badalprasadsingh badalprasadsingh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will test this after these changes are made.

Comment thread .github/workflows/license-check.yml Outdated
Comment thread .github/workflows/license-check.yml Outdated
Comment thread .github/workflows/license-check.yml Outdated
Comment thread .github/workflows/license-check.yml Outdated

@badalprasadsingh badalprasadsingh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one edge case:

If we delete a certain file, directory or module, which we eventually are going to do: There won't be any modification note. Let's discuss tomorrow on this.

Also, change the file name to modification-header-check.yml

Comment thread .github/workflows/license-check.yml Outdated
Comment thread .github/workflows/license-check.yml Outdated
Comment thread .github/workflows/license-check.yml Outdated
Comment thread .github/workflows/license-check.yml Outdated
Comment thread .github/workflows/license-check.yml Outdated
Comment thread .github/workflows/license-check.yml Outdated
@badalprasadsingh

badalprasadsingh commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator

Cases Checked:

  • renaming an existing file, will require modification check
  • deleting a file or module, won't need any modification check
  • creating a new file or modifying a file will require modification check (in first 40 lines)
  • only runs for master and staging branch

One test case remains: if any file is .jpg, or .json we cannot add the modified line there. But in that case the PR owner, can add that case in the .yml workflow to skip those files, just like we do in integration tests.

@arsalan-datazip arsalan-datazip changed the title feat: add license header check workflow feat: modification-header-check Feb 24, 2026
@hash-data hash-data merged commit 3db632b into staging Feb 27, 2026
2 checks passed
@hash-data hash-data deleted the ci/license-header-check branch February 27, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants